Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Bug: Equipment crafting cancellation gives flat 50% refund regardless of progress #216

New Issue
Closed
opened 2026-05-30 19:46:58 +02:00 by Anexim · 1 comment
Anexim commented 2026-05-30 19:46:58 +02:00
Owner
Copy Link
Copy Source

Bug Description

When cancelling equipment crafting, the player receives a flat 50% refund of the total mana cost, regardless of how much progress has been made. This means cancelling at 99% completion still refunds 50% of the full cost.

Code Location

  • src/lib/game/crafting-equipment.ts lines 125-130: cancelEquipmentCrafting uses manaSpent (total recipe cost) for the refund calculation
  • src/lib/game/stores/craftingStore.ts lines 208-215: cancelEquipmentCrafting action passes progress.manaSpent (total cost, not remaining)
const manaRefund = Math.floor(manaSpent * MANA_REFUND_RATE);

Impact

Players can exploit this by:

  1. Starting expensive crafts
  2. Letting them progress almost to completion
  3. Cancelling for a flat 50% refund
  4. Repeating to effectively get a 50% discount on all crafting

Fix Required

The refund should be proportional to remaining progress:

const remainingRatio = 1 - (progress.currentProgress / progress.required);
const manaRefund = Math.floor(manaSpent * remainingRatio * MANA_REFUND_RATE);

Or alternatively, track manaAlreadySpent separately from manaRemaining and refund based on remaining.

## Bug Description When cancelling equipment crafting, the player receives a flat 50% refund of the **total** mana cost, regardless of how much progress has been made. This means cancelling at 99% completion still refunds 50% of the full cost. ## Code Location - `src/lib/game/crafting-equipment.ts` lines 125-130: `cancelEquipmentCrafting` uses `manaSpent` (total recipe cost) for the refund calculation - `src/lib/game/stores/craftingStore.ts` lines 208-215: `cancelEquipmentCrafting` action passes `progress.manaSpent` (total cost, not remaining) ```typescript const manaRefund = Math.floor(manaSpent * MANA_REFUND_RATE); ``` ## Impact Players can exploit this by: 1. Starting expensive crafts 2. Letting them progress almost to completion 3. Cancelling for a flat 50% refund 4. Repeating to effectively get a 50% discount on all crafting ## Fix Required The refund should be proportional to remaining progress: ```typescript const remainingRatio = 1 - (progress.currentProgress / progress.required); const manaRefund = Math.floor(manaSpent * remainingRatio * MANA_REFUND_RATE); ``` Or alternatively, track `manaAlreadySpent` separately from `manaRemaining` and refund based on remaining.
Anexim added the ai:todo label 2026-05-30 19:46:58 +02:00
n8n-gitea was assigned by Anexim 2026-05-30 19:46:58 +02:00
Anexim commented 2026-05-30 22:29:27 +02:00
Author
Owner
Copy Link
Copy Source

Fixed: Equipment crafting cancellation now refunds proportionally to remaining progress instead of a flat 50%. Also added material refund on cancellation in craftingStore.ts. The refund rate is: full refund for unspent progress + 50% for spent progress.

Fixed: Equipment crafting cancellation now refunds proportionally to remaining progress instead of a flat 50%. Also added material refund on cancellation in craftingStore.ts. The refund rate is: full refund for unspent progress + 50% for spent progress.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#216
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?