Bug: Guardians never marked as defeated — pact ritual unreachable #220

New Issue

2026-05-30T21:10:32+02:00

Anexim commented

2026-05-30 21:10:32 +02:00

Bug Description

When a guardian is defeated during combat, the prestige store is never notified. The onFloorCleared callback in gameStore.ts only logs a message and resets shield/barrier state — it never calls defeatGuardian() or addDefeatedGuardian().

Code Location

src/lib/game/stores/gameStore.ts lines 270-277:

(floor, wasGuardian) => {
  if (wasGuardian) {
    const defeatedGuardian = getGuardianForFloor(floor);
    addLog((defeatedGuardian?.name || 'Unknown') + ' defeated! Visit the Grimoire to sign a pact.');
  }
  // Missing: usePrestigeStore.getState().defeatGuardian(floor);
}

Impact

Critical. The defeatedGuardians array is never populated during normal gameplay. Since startPactRitual checks defeatedGuardians.includes(floor), players can never start a pact ritual through normal gameplay. The entire pact-signing flow is unreachable without debug commands.

Fix Required

Add usePrestigeStore.getState().defeatGuardian(floor) (or equivalent) to the wasGuardian branch of the onFloorCleared callback.

## Bug Description When a guardian is defeated during combat, the prestige store is never notified. The `onFloorCleared` callback in `gameStore.ts` only logs a message and resets shield/barrier state — it never calls `defeatGuardian()` or `addDefeatedGuardian()`. ## Code Location `src/lib/game/stores/gameStore.ts` lines 270-277: ```typescript (floor, wasGuardian) => { if (wasGuardian) { const defeatedGuardian = getGuardianForFloor(floor); addLog((defeatedGuardian?.name || 'Unknown') + ' defeated! Visit the Grimoire to sign a pact.'); } // Missing: usePrestigeStore.getState().defeatGuardian(floor); } ``` ## Impact **Critical.** The `defeatedGuardians` array is never populated during normal gameplay. Since `startPactRitual` checks `defeatedGuardians.includes(floor)`, players can never start a pact ritual through normal gameplay. The entire pact-signing flow is unreachable without debug commands. ## Fix Required Add `usePrestigeStore.getState().defeatGuardian(floor)` (or equivalent) to the `wasGuardian` branch of the `onFloorCleared` callback.

Anexim added the ai:todo label 2026-05-30 21:10:32 +02:00

n8n-gitea was assigned by Anexim

2026-05-30 21:10:32 +02:00

Anexim referenced this issue

2026-05-30 21:31:21 +02:00

Priority: Bug fix priority ordering #228

n8n-gitea referenced this issue from a commit

2026-05-30 22:28:56 +02:00

fix: Bug fixes #218 #222 #220 #223 #215 #216 - attunement free mana, transference circular ref, guardian defeat tracking, discipline negative mana, guardian data, crafting refunds

Anexim closed this issue

2026-05-30 22:29:26 +02:00

Anexim commented

2026-05-30 22:29:26 +02:00

Fixed: Added usePrestigeStore.getState().addDefeatedGuardian(floor) call in the onFloorCleared callback in gameStore.ts. Guardians are now properly tracked as defeated, making the pact ritual reachable.

Anexim referenced this issue

2026-05-30 22:29:56 +02:00

Priority: Bug fix priority ordering #228

Anexim referenced this issue

2026-05-31 01:18:51 +02:00

Priority: Bug fix priority ordering #228

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#220