Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Bug: regen-transference discipline has source=transference (circular reference) #222

New Issue
Closed
opened 2026-05-30 21:10:33 +02:00 by Anexim · 1 comment
Anexim commented 2026-05-30 21:10:33 +02:00
Owner
Copy Link
Copy Source

Bug Description

The regen-transference discipline has sourceManaTypes: ['transference'] — meaning it consumes transference mana to produce transference mana. Combined with the discipline's own drain also being in transference, the net effect is that running this discipline drains transference without ever producing any net gain.

Code Location

src/lib/game/data/disciplines/elemental-regen.ts (around line 92):

// regen-transference discipline
sourceManaTypes: ['transference'],  // BUG: should be ['raw']
manaType: 'transference',

In gameStore.ts lines 214+, the discipline conversion:

  1. Drains transference (source) by conversionAmount
  2. Adds transference (target, same as source) by conversionAmount → net zero
  3. Meanwhile, the discipline tick processing drains transference as its XP cost

So the discipline drains transference as cost, and the "conversion" replaces exactly what was drained. Net result: zero transference gained, while the discipline requires transference to keep running.

Impact

Critical design bug. Transference can never be accumulated through the discipline system. Combined with the attunement conversion bug (#218 — free mana with no source drain), the element economy is fundamentally broken. Transference is the only base-unlocked element, making this a blocking issue for early game progression.

Fix Required

Change sourceManaTypes from ['transference'] to ['raw'] so the discipline converts raw mana into transference, matching all other base-element conversion disciplines.

## Bug Description The `regen-transference` discipline has `sourceManaTypes: ['transference']` — meaning it consumes transference mana to produce transference mana. Combined with the discipline's own drain also being in transference, the net effect is that running this discipline **drains transference without ever producing any net gain**. ## Code Location `src/lib/game/data/disciplines/elemental-regen.ts` (around line 92): ```typescript // regen-transference discipline sourceManaTypes: ['transference'], // BUG: should be ['raw'] manaType: 'transference', ``` In `gameStore.ts` lines 214+, the discipline conversion: 1. Drains `transference` (source) by `conversionAmount` 2. Adds `transference` (target, same as source) by `conversionAmount` → net zero 3. Meanwhile, the discipline tick processing drains transference as its XP cost So the discipline drains transference as cost, and the "conversion" replaces exactly what was drained. Net result: **zero transference gained**, while the discipline requires transference to keep running. ## Impact **Critical design bug.** Transference can never be accumulated through the discipline system. Combined with the attunement conversion bug (#218 — free mana with no source drain), the element economy is fundamentally broken. Transference is the only base-unlocked element, making this a blocking issue for early game progression. ## Fix Required Change `sourceManaTypes` from `['transference']` to `['raw']` so the discipline converts raw mana into transference, matching all other base-element conversion disciplines.
Anexim added the ai:todo label 2026-05-30 21:10:33 +02:00
n8n-gitea was assigned by Anexim 2026-05-30 21:10:33 +02:00
Anexim commented 2026-05-30 22:29:25 +02:00
Author
Owner
Copy Link
Copy Source

Fixed: Changed regen-transference discipline sourceManaTypes from ['transference'] to ['raw'] in elemental-regen.ts. The discipline now correctly converts raw mana into transference instead of having a circular reference.

Fixed: Changed regen-transference discipline sourceManaTypes from ['transference'] to ['raw'] in elemental-regen.ts. The discipline now correctly converts raw mana into transference instead of having a circular reference.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#222
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?