Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Bug: Equipment spell kills don't advance floor (1-tick delay) #226

New Issue
Closed
opened 2026-05-30 21:10:34 +02:00 by Anexim · 1 comment
Anexim commented 2026-05-30 21:10:34 +02:00
Owner
Copy Link
Copy Source

Bug Description

When an equipment spell delivers the killing blow to a floor, the floor advance logic doesn't run. The equipment spell loop just breaks without:

  • Calling onFloorCleared
  • Advancing currentFloor
  • Resetting floorHP to the new floor's max
  • Resetting castProgress

The floor advance happens on the next tick when the primary spell loop sees floorHP <= 0, causing a 1-tick delay.

Code Location

src/lib/game/stores/combat-actions.ts lines ~155-158 (equipment spell loop):

if (floorHP <= 0) break; // Floor cleared, stop processing
// Missing: onFloorCleared, floor advance, etc.

Compare with the primary spell loop (lines ~107-117) which properly advances the floor and calls onFloorCleared.

Impact

Minor. Floor advancement is delayed by one tick when equipment spells deliver the killing blow. The onFloorCleared callback (which grants rewards) is also delayed. This creates an inconsistency between primary spell kills (instant) and equipment spell kills (delayed).

Fix Required

Add the same floor-clear logic in the equipment spell loop as the primary spell loop: call onFloorCleared, advance currentFloor, reset floorHP, and reset castProgress.

## Bug Description When an equipment spell delivers the killing blow to a floor, the floor advance logic doesn't run. The equipment spell loop just `break`s without: - Calling `onFloorCleared` - Advancing `currentFloor` - Resetting `floorHP` to the new floor's max - Resetting `castProgress` The floor advance happens on the **next tick** when the primary spell loop sees `floorHP <= 0`, causing a 1-tick delay. ## Code Location `src/lib/game/stores/combat-actions.ts` lines ~155-158 (equipment spell loop): ```typescript if (floorHP <= 0) break; // Floor cleared, stop processing // Missing: onFloorCleared, floor advance, etc. ``` Compare with the primary spell loop (lines ~107-117) which properly advances the floor and calls `onFloorCleared`. ## Impact **Minor.** Floor advancement is delayed by one tick when equipment spells deliver the killing blow. The `onFloorCleared` callback (which grants rewards) is also delayed. This creates an inconsistency between primary spell kills (instant) and equipment spell kills (delayed). ## Fix Required Add the same floor-clear logic in the equipment spell loop as the primary spell loop: call `onFloorCleared`, advance `currentFloor`, reset `floorHP`, and reset `castProgress`.
Anexim added the ai:todo label 2026-05-30 21:10:34 +02:00
n8n-gitea was assigned by Anexim 2026-05-30 21:10:34 +02:00
Anexim commented 2026-05-31 01:19:17 +02:00
Author
Owner
Copy Link
Copy Source

Fixed: Equipment spell loop now includes floor-clear logic (onFloorCleared, floor advance, HP reset, castProgress reset) matching the primary spell loop.

Fixed: Equipment spell loop now includes floor-clear logic (onFloorCleared, floor advance, HP reset, castProgress reset) matching the primary spell loop.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#226
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?