Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

[High] [Bug] Pact System: Raw mana cost never deducted when starting pact ritual #306

New Issue
Closed
opened 2026-06-07 17:42:19 +02:00 by Anexim · 3 comments
Anexim commented 2026-06-07 17:42:19 +02:00
Owner
Copy Link
Copy Source

Spec: docs/specs/attunements/invoker/systems/pact-system-spec.md §2.2 step 7
Severity: High

Problem: src/lib/game/stores/prestigeStore.ts:97-108 — startPactRitual() validates rawMana < guardian.pactCost but never deducts the cost. The spec explicitly says "Deduct guardian.pactCost raw mana" and the cancellation rule says "not refunded on cancellation," implying it should have been deducted upfront.

File: src/lib/game/stores/prestigeStore.ts:97-108

**Spec:** docs/specs/attunements/invoker/systems/pact-system-spec.md §2.2 step 7 **Severity:** High **Problem:** `src/lib/game/stores/prestigeStore.ts:97-108` — `startPactRitual()` validates `rawMana < guardian.pactCost` but **never deducts the cost**. The spec explicitly says "Deduct guardian.pactCost raw mana" and the cancellation rule says "not refunded on cancellation," implying it should have been deducted upfront. **File:** `src/lib/game/stores/prestigeStore.ts:97-108`
Anexim added the ai:todo label 2026-06-07 17:42:19 +02:00
n8n-gitea was assigned by Anexim 2026-06-07 17:42:19 +02:00
Anexim added ai:in-progress and removed ai:todo labels 2026-06-08 11:13:18 +02:00
Anexim commented 2026-06-08 11:13:18 +02:00
Author
Owner
Copy Link
Copy Source

Starting investigation of Issue #306: Pact System raw mana cost never deducted when starting pact ritual.

Starting investigation of Issue #306: Pact System raw mana cost never deducted when starting pact ritual.
Anexim commented 2026-06-08 11:13:44 +02:00
Author
Owner
Copy Link
Copy Source

Bug confirmed. In startPactRitual() (prestigeStore.ts:97-108), the function validates rawMana < guardian.pactCost but never deducts the cost. Per spec §2.2 step 7: "Deduct guardian.pactCost raw mana". The spec §2.5 also confirms the cost should NOT be refunded on cancellation, implying it must be deducted upfront at start.

Root cause: The startPactRitual function only sets pactRitualFloor and pactRitualProgress, but never calls any mana deduction method.

Fix plan: After all validations pass and before set(), deduct guardian.pactCost from raw mana using useManaStore.getState().spendMana() or equivalent. Need to check the mana store API first.

**Bug confirmed.** In `startPactRitual()` (prestigeStore.ts:97-108), the function validates `rawMana < guardian.pactCost` but never deducts the cost. Per spec §2.2 step 7: "Deduct guardian.pactCost raw mana". The spec §2.5 also confirms the cost should NOT be refunded on cancellation, implying it must be deducted upfront at start. **Root cause:** The `startPactRitual` function only sets `pactRitualFloor` and `pactRitualProgress`, but never calls any mana deduction method. **Fix plan:** After all validations pass and before `set()`, deduct `guardian.pactCost` from raw mana using `useManaStore.getState().spendMana()` or equivalent. Need to check the mana store API first.
Anexim added ai:done and removed ai:in-progress labels 2026-06-08 11:21:30 +02:00
Anexim commented 2026-06-08 11:21:31 +02:00
Author
Owner
Copy Link
Copy Source

Fix complete. Added useManaStore.getState().spendRawMana(guardian.pactCost) call in startPactRitual() after all validations pass, before setting ritual state. This implements spec §2.2 step 7: "Deduct guardian.pactCost raw mana".

Changes:

  • src/lib/game/stores/prestigeStore.ts — Added mana deduction after validation guards in startPactRitual()
  • src/lib/game/__tests__/store-actions-combat-prestige.test.ts — Added 2 regression tests:
    1. "should deduct raw mana cost when starting ritual" — verifies mana is deducted on successful ritual start
    2. "should NOT deduct raw mana when ritual fails" — verifies mana is NOT deducted when validation fails
    • Also fixed existing test "should start ritual when conditions met" to set mana store state (previously passed only because deduction was missing)

Verification: All 54 test files (1043 tests) pass.

**Fix complete.** Added `useManaStore.getState().spendRawMana(guardian.pactCost)` call in `startPactRitual()` after all validations pass, before setting ritual state. This implements spec §2.2 step 7: "Deduct guardian.pactCost raw mana". **Changes:** - `src/lib/game/stores/prestigeStore.ts` — Added mana deduction after validation guards in `startPactRitual()` - `src/lib/game/__tests__/store-actions-combat-prestige.test.ts` — Added 2 regression tests: 1. "should deduct raw mana cost when starting ritual" — verifies mana is deducted on successful ritual start 2. "should NOT deduct raw mana when ritual fails" — verifies mana is NOT deducted when validation fails - Also fixed existing test "should start ritual when conditions met" to set mana store state (previously passed only because deduction was missing) **Verification:** All 54 test files (1043 tests) pass.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:done
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#306
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?