Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

[High] [Bug] Item fabrication: wizard unlock thresholds shifted +50 XP, duplicate enchantment on aetherRobe #327

New Issue
Closed
opened 2026-06-08 16:02:45 +02:00 by Anexim · 2 comments
Anexim commented 2026-06-08 16:02:45 +02:00
Owner
Copy Link
Copy Source

Spec: docs/specs/attunements/fabricator/systems/item-fabrication-spec.md

Discrepancies found:

Wizard branch unlock thresholds shifted +50 XP [HIGH]

  • Arcanist Circlet & Robe: Spec says 150, code has them at 200 (perk wizard-arcanist-gear at threshold 200)
  • Void Catalyst: Spec says 200, code has it at 250 (perk wizard-void-catalyst at threshold 250)
  • Arcanist Pendant: Spec says 250, code has it at 300 (perk wizard-arcanist-pendant at threshold 300)
  • File: src/lib/game/data/disciplines/fabricator.ts
  • Fix: Either update code thresholds to match spec, or update spec to match code

Duplicate crystal_cap_10 enchantment on aetherRobe [HIGH]

  • File: src/lib/game/data/fabricator-wizard-recipes.ts
  • aetherRobe has crystal_cap_10 listed twice in bonusEnchantments (lines 133-136)
  • Grants +20 crystal cap instead of intended +10
  • Fix: Remove duplicate entry

Spec §10 rarity distribution counts don't match actual recipe counts [MEDIUM]

  • Spec says uncommon=14, rare=14 for equipment, but code has uncommon=8, rare=11, epic=9, legendary=4 for equipment recipes (33 total)
  • Spec's math (14+14+10+5=43) doesn't equal the 33 equipment recipes
  • Fix: Update spec to match actual code distribution

Material recipes have rarities not accounted for in spec §10 [MEDIUM]

  • fireCrystal through metalCrystal are rare, crystalCrystal is epic, elementalCore is epic
  • Spec's rarity table only mentions 2 common items but doesn't classify the other 13 material recipes
  • Fix: Update spec to include material recipe rarities
**Spec:** `docs/specs/attunements/fabricator/systems/item-fabrication-spec.md` **Discrepancies found:** ### Wizard branch unlock thresholds shifted +50 XP [HIGH] - **Arcanist Circlet & Robe:** Spec says 150, code has them at **200** (perk `wizard-arcanist-gear` at threshold 200) - **Void Catalyst:** Spec says 200, code has it at **250** (perk `wizard-void-catalyst` at threshold 250) - **Arcanist Pendant:** Spec says 250, code has it at **300** (perk `wizard-arcanist-pendant` at threshold 300) - **File:** `src/lib/game/data/disciplines/fabricator.ts` - **Fix:** Either update code thresholds to match spec, or update spec to match code ### Duplicate `crystal_cap_10` enchantment on aetherRobe [HIGH] - **File:** `src/lib/game/data/fabricator-wizard-recipes.ts` - `aetherRobe` has `crystal_cap_10` listed twice in `bonusEnchantments` (lines 133-136) - Grants +20 crystal cap instead of intended +10 - **Fix:** Remove duplicate entry ### Spec §10 rarity distribution counts don't match actual recipe counts [MEDIUM] - Spec says uncommon=14, rare=14 for equipment, but code has uncommon=8, rare=11, epic=9, legendary=4 for equipment recipes (33 total) - Spec's math (14+14+10+5=43) doesn't equal the 33 equipment recipes - **Fix:** Update spec to match actual code distribution ### Material recipes have rarities not accounted for in spec §10 [MEDIUM] - fireCrystal through metalCrystal are `rare`, crystalCrystal is `epic`, elementalCore is `epic` - Spec's rarity table only mentions 2 common items but doesn't classify the other 13 material recipes - **Fix:** Update spec to include material recipe rarities
Anexim added the ai:todo label 2026-06-08 16:02:45 +02:00
n8n-gitea was assigned by Anexim 2026-06-08 16:02:45 +02:00
Anexim added ai:in-progress and removed ai:todo labels 2026-06-08 23:47:38 +02:00
Anexim commented 2026-06-08 23:49:44 +02:00
Author
Owner
Copy Link
Copy Source

Fix Summary for Issue #327

1. Wizard unlock thresholds shifted +50 XP — FIXED

File: src/lib/game/data/disciplines/fabricator.ts

  • wizard-arcanist-gear: threshold 200 → 150 (matches spec)
  • wizard-void-catalyst: threshold 250 → 200 (matches spec)
  • wizard-arcanist-pendant: threshold 300 → 250 (matches spec)

2. Duplicate crystal_cap_10 enchantment on aetherRobe — FIXED

File: src/lib/game/data/fabricator-wizard-recipes.ts

  • Removed duplicate { effectId: 'crystal_cap_10', stacks: 1, actualCost: 30 } entry
  • aetherRobe now grants +10 crystal cap (was incorrectly +20)

3. Spec §10 rarity distribution — UPDATED

File: docs/specs/attunements/fabricator/systems/item-fabrication-spec.md

  • Replaced incorrect rarity table with accurate counts from code:
    • Material recipes (15): common=2, uncommon=1, rare=7, epic=4, legendary=1
    • Equipment recipes (33): uncommon=8, rare=11, epic=9, legendary=4
    • Combined totals (48): common=2, uncommon=9, rare=18, epic=13, legendary=5

Tests

  • All 59 test files passed (1086 tests) — no regressions
## Fix Summary for Issue #327 ### 1. Wizard unlock thresholds shifted +50 XP — FIXED **File:** `src/lib/game/data/disciplines/fabricator.ts` - `wizard-arcanist-gear`: threshold 200 → **150** (matches spec) - `wizard-void-catalyst`: threshold 250 → **200** (matches spec) - `wizard-arcanist-pendant`: threshold 300 → **250** (matches spec) ### 2. Duplicate `crystal_cap_10` enchantment on aetherRobe — FIXED **File:** `src/lib/game/data/fabricator-wizard-recipes.ts` - Removed duplicate `{ effectId: 'crystal_cap_10', stacks: 1, actualCost: 30 }` entry - aetherRobe now grants +10 crystal cap (was incorrectly +20) ### 3. Spec §10 rarity distribution — UPDATED **File:** `docs/specs/attunements/fabricator/systems/item-fabrication-spec.md` - Replaced incorrect rarity table with accurate counts from code: - Material recipes (15): common=2, uncommon=1, rare=7, epic=4, legendary=1 - Equipment recipes (33): uncommon=8, rare=11, epic=9, legendary=4 - Combined totals (48): common=2, uncommon=9, rare=18, epic=13, legendary=5 ### Tests - All 59 test files passed (1086 tests) — no regressions
Anexim added ai:done and removed ai:in-progress labels 2026-06-08 23:50:21 +02:00
Anexim commented 2026-06-08 23:50:21 +02:00
Author
Owner
Copy Link
Copy Source

All 4 fixes applied and committed. See comment above for details.

All 4 fixes applied and committed. See comment above for details.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:done
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#327
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?