Anexim/Mana-Loop
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: Duplicate RARITY_COLORS constants with different values #36

New Issue
Closed
opened 2026-05-18 15:59:26 +02:00 by Anexim · 3 comments
Anexim commented 2026-05-18 15:59:26 +02:00
Owner
Copy Link
Copy Source

Severity: Major

Files:

  • src/lib/game/constants/core.ts (lines 11-19) — RARITY_COLORS with legendary: '#F97316'
  • src/lib/game/data/loot-drops.ts (lines 155-163) — RARITY_COLORS with legendary: '#F59E0B' and extra glow property

Problem: Two different RARITY_COLORS constants with different structures and values exist. The loot-drops version has an extra glow field and a different color for legendary items. These serve different purposes but the naming collision is confusing.

Impact: Inconsistent rarity colors across the UI. Developers may import from the wrong file.

Fix: Rename one of them (e.g., RARITY_COLORS in loot-drops.ts → LOOT_RARITY_COLORS) or consolidate into a single shared constant.

**Severity:** Major **Files:** - `src/lib/game/constants/core.ts` (lines 11-19) — `RARITY_COLORS` with `legendary: '#F97316'` - `src/lib/game/data/loot-drops.ts` (lines 155-163) — `RARITY_COLORS` with `legendary: '#F59E0B'` and extra `glow` property **Problem:** Two different `RARITY_COLORS` constants with different structures and values exist. The loot-drops version has an extra `glow` field and a different color for legendary items. These serve different purposes but the naming collision is confusing. **Impact:** Inconsistent rarity colors across the UI. Developers may import from the wrong file. **Fix:** Rename one of them (e.g., `RARITY_COLORS` in loot-drops.ts → `LOOT_RARITY_COLORS`) or consolidate into a single shared constant.
Anexim added the ai:todo label 2026-05-18 15:59:26 +02:00
n8n-gitea was assigned by Anexim 2026-05-18 15:59:26 +02:00
Anexim commented 2026-05-18 17:11:35 +02:00
Author
Owner
Copy Link
Copy Source

[priority: 3] DATA/LOGIC BUG — Duplicate RARITY_COLORS constants with different values.

[priority: 3] DATA/LOGIC BUG — Duplicate RARITY_COLORS constants with different values.
Anexim commented 2026-05-18 19:54:40 +02:00
Author
Owner
Copy Link
Copy Source

Starting work on #36. Will rename duplicate RARITY_COLORS in loot-drops.ts to LOOT_RARITY_COLORS.

Starting work on #36. Will rename duplicate RARITY_COLORS in loot-drops.ts to LOOT_RARITY_COLORS.
Anexim commented 2026-05-18 20:08:57 +02:00
Author
Owner
Copy Link
Copy Source

Fixed. Renamed RARITY_COLORS in loot-drops.ts to LOOT_RARITY_COLORS to avoid naming collision with the RARITY_COLORS in constants/core.ts. Updated all consumers (EquipmentCrafter.tsx, LootInventory/index.tsx, LootInventory/types.ts) to use the renamed export.

Fixed. Renamed RARITY_COLORS in loot-drops.ts to LOOT_RARITY_COLORS to avoid naming collision with the RARITY_COLORS in constants/core.ts. Updated all consumers (EquipmentCrafter.tsx, LootInventory/index.tsx, LootInventory/types.ts) to use the renamed export.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#36
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?