fix: golems/utils.ts and equipment/utils.ts duplicate local constants instead of importing from index #40

New Issue

2026-05-18T16:01:00+02:00

Anexim commented

2026-05-18 16:01:00 +02:00

Severity: Major

Files:

src/lib/game/data/golems/utils.ts (lines 8-13) — creates local GOLEMS_DEF by spreading BASE_GOLEMS, ELEMENTAL_GOLEMS, HYBRID_GOLEMS
src/lib/game/data/equipment/utils.ts (lines 13-24) — creates local EQUIPMENT_TYPES by spreading all equipment category arrays

Problem: Both files recreate their respective definition constants locally instead of importing from their ./index.ts barrel files. This creates a maintenance risk — if a new golem category or equipment category is added to the index but not to the local spread in utils, the utility functions won't see the new entries.

Impact: New golem or equipment types added to the index won't be visible to utility functions like getGolemDef(), getAvailableDrops(), etc. Silent data loss.

Fix: Import from the index files instead:

// golems/utils.ts
import { GOLEMS_DEF } from './index';

// equipment/utils.ts
import { EQUIPMENT_TYPES } from './index';

**Severity:** Major **Files:** - `src/lib/game/data/golems/utils.ts` (lines 8-13) — creates local `GOLEMS_DEF` by spreading `BASE_GOLEMS`, `ELEMENTAL_GOLEMS`, `HYBRID_GOLEMS` - `src/lib/game/data/equipment/utils.ts` (lines 13-24) — creates local `EQUIPMENT_TYPES` by spreading all equipment category arrays **Problem:** Both files recreate their respective definition constants locally instead of importing from their `./index.ts` barrel files. This creates a maintenance risk — if a new golem category or equipment category is added to the index but not to the local spread in utils, the utility functions won't see the new entries. **Impact:** New golem or equipment types added to the index won't be visible to utility functions like `getGolemDef()`, `getAvailableDrops()`, etc. Silent data loss. **Fix:** Import from the index files instead: ```ts // golems/utils.ts import { GOLEMS_DEF } from './index'; // equipment/utils.ts import { EQUIPMENT_TYPES } from './index'; ```

Anexim added the ai:todo label 2026-05-18 16:01:00 +02:00

n8n-gitea was assigned by Anexim

2026-05-18 16:01:00 +02:00

Anexim commented

2026-05-18 17:11:33 +02:00

[priority: 3] DATA/LOGIC BUG — golems/utils.ts and equipment/utils.ts duplicate local constants instead of importing from index.

Anexim referenced this issue

2026-05-18 17:13:10 +02:00

📋 Project-wide issue prioritization complete — 36 issues ranked [priority: 1-5] #66

Anexim commented

2026-05-18 19:54:38 +02:00

Starting work on #40. Will fix golems/utils.ts and equipment/utils.ts to import from index instead of duplicating constants.

Anexim closed this issue

2026-05-18 20:08:56 +02:00

Anexim commented

2026-05-18 20:08:56 +02:00

Fixed. Updated golems/utils.ts to import GOLEMS_DEF from './index' instead of locally spreading BASE/ELEMENTAL/HYBRID_GOLEMS. Updated equipment/utils.ts to import EQUIPMENT_TYPES from './index' instead of locally spreading all equipment category arrays.

n8n-gitea referenced this issue from a commit

2026-05-18 20:10:02 +02:00

fix: resolve all Priority 4 and Priority 3 issues (18 issues total)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#40