fix: Missing enchantment effects for several spells (rotTouch, soulRend, master, legendary) #41
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Severity: Major
Files:
src/lib/game/data/enchantments/spell-effects/basic-spells.ts— missingspell_rotTouch(death element Tier 1)src/lib/game/data/enchantments/spell-effects/tier2-spells.ts— missingspell_soulRend(death element Tier 2)src/lib/game/data/enchantments/spell-effects/tier3-spells.ts— only haspyroclasm,tsunami,meteorStrike; missingcosmicStorm,heavenLight,oblivion,deathMark(master spells), and allLEGENDARY_SPELLS(stellarNova,voidCollapse,crystalShatter)Problem: Several spells have no defined enchantment effects, meaning they cannot be applied as equipment enchantments. This creates an incomplete enchantment system where some spells are missing from the crafting flow.
Impact: Players cannot create enchantments for death element spells, master spells, or legendary spells. The enchantment system is incomplete.
Fix: Add missing enchantment effect definitions for all spells that are missing them. Each should follow the pattern of existing effects with appropriate
baseCapacityCost,allowedEquipmentCategories, andeffectconfiguration.[priority: 3] DATA/LOGIC BUG — Missing enchantment effects for several spells (rotTouch, soulRend, master, legendary).
Starting work on #41 — adding missing enchantment effects for rotTouch, soulRend, master spells, and legendary spells. This is the highest priority remaining issue (Priority 3).
Fixed. Added missing enchantment effects for all spells that were missing them:
Tier 1 (basic-spells.ts):
spell_rotTouch— death element, 14 damage, baseCapacityCost: 80Tier 2 (tier2-spells.ts):
spell_soulRend— death element, 50 damage, baseCapacityCost: 170Tier 3 Master Spells (tier3-spells.ts):
spell_cosmicStorm— air, 200 damage, baseCapacityCost: 370spell_heavenLight— light, 240 damage, baseCapacityCost: 390spell_oblivion— dark, 230 damage, baseCapacityCost: 385spell_deathMark— death, 200 damage, baseCapacityCost: 370Tier 4 Legendary Spells (new file: legendary-spells.ts):
spell_stellarNova— stellar, 500 damage, baseCapacityCost: 600spell_voidCollapse— void, 450 damage, baseCapacityCost: 550spell_crystalShatter— crystal, 400 damage, baseCapacityCost: 500Updated
spell-effects/index.tsto import and includeLEGENDARY_SPELL_EFFECTSin the combinedSPELL_EFFECTSrecord. All effects follow the existing pattern withALL_CASTERequipment category. All files pass pre-commit size checks (under 400 lines).