fix: ConfirmDialog silently swallows async errors from onConfirm #47

New Issue

2026-05-18T16:02:33+02:00

Anexim commented

2026-05-18 16:02:33 +02:00

Severity: Major

File: src/components/game/ConfirmDialog.tsx (lines 102-112)

Problem: The handleConfirm function catches errors in a finally block but doesn't display them to the user. If onConfirm() throws, the dialog closes silently with no feedback that the action failed.

Impact: Users get no feedback when confirm actions fail. They may think an action succeeded when it actually failed.

Fix: Add error state and display it in the dialog:

const [error, setError] = useState<string | null>(null);
// In handleConfirm:
try {
  await onConfirm();
  onClose();
} catch (e) {
  setError(e instanceof Error ? e.message : 'Action failed');
}

**Severity:** Major **File:** `src/components/game/ConfirmDialog.tsx` (lines 102-112) **Problem:** The `handleConfirm` function catches errors in a `finally` block but doesn't display them to the user. If `onConfirm()` throws, the dialog closes silently with no feedback that the action failed. **Impact:** Users get no feedback when confirm actions fail. They may think an action succeeded when it actually failed. **Fix:** Add error state and display it in the dialog: ```ts const [error, setError] = useState<string | null>(null); // In handleConfirm: try { await onConfirm(); onClose(); } catch (e) { setError(e instanceof Error ? e.message : 'Action failed'); } ```

Anexim added the ai:todo label 2026-05-18 16:02:33 +02:00

n8n-gitea was assigned by Anexim

2026-05-18 16:02:33 +02:00

Anexim commented

2026-05-18 17:10:43 +02:00

[priority: 4] BROKEN FEATURE — ConfirmDialog silently swallows async errors from onConfirm.

Anexim referenced this issue

2026-05-18 17:13:10 +02:00

📋 Project-wide issue prioritization complete — 36 issues ranked [priority: 1-5] #66

Anexim commented

2026-05-18 19:47:24 +02:00

Starting work on #47. Reading ConfirmDialog.tsx to fix async error swallowing.

Anexim closed this issue

2026-05-18 19:51:56 +02:00

Anexim commented

2026-05-18 19:51:56 +02:00

Fixed. Added error state to ConfirmDialog. The handleConfirm function now catches errors from onConfirm() and displays them in a red error box inside the dialog instead of silently swallowing them. The dialog stays open when an error occurs so the user can see the failure message.

n8n-gitea referenced this issue from a commit

2026-05-18 20:10:02 +02:00

fix: resolve all Priority 4 and Priority 3 issues (18 issues total)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#47