Anexim/Mana-Loop
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: doPrestige return type mismatch — interface says void but returns boolean #48

New Issue
Closed
opened 2026-05-18 16:02:33 +02:00 by Anexim · 3 comments
Anexim commented 2026-05-18 16:02:33 +02:00
Owner
Copy Link
Copy Source

Severity: Major

File: src/lib/game/stores/prestigeStore.ts (lines 94-103)

Problem: doPrestige returns false on failure and true/undefined on success, but the PrestigeState interface declares it as () => void. This is a type mismatch — TypeScript won't catch callers trying to use the return value, and the interface lies about the contract.

Impact: Type safety issue. Callers who check the return value get no type support. The interface is misleading.

Fix: Update the PrestigeState interface to declare doPrestige: (id: string) => boolean.

**Severity:** Major **File:** `src/lib/game/stores/prestigeStore.ts` (lines 94-103) **Problem:** `doPrestige` returns `false` on failure and `true`/`undefined` on success, but the `PrestigeState` interface declares it as `() => void`. This is a type mismatch — TypeScript won't catch callers trying to use the return value, and the interface lies about the contract. **Impact:** Type safety issue. Callers who check the return value get no type support. The interface is misleading. **Fix:** Update the `PrestigeState` interface to declare `doPrestige: (id: string) => boolean`.
Anexim added the ai:todo label 2026-05-18 16:02:33 +02:00
n8n-gitea was assigned by Anexim 2026-05-18 16:02:33 +02:00
Anexim commented 2026-05-18 17:10:43 +02:00
Author
Owner
Copy Link
Copy Source

[priority: 4] BROKEN FEATURE — doPrestige return type mismatch (interface says void, returns boolean).

[priority: 4] BROKEN FEATURE — doPrestige return type mismatch (interface says void, returns boolean).
Anexim commented 2026-05-18 19:47:23 +02:00
Author
Owner
Copy Link
Copy Source

Starting work on #48. Reading prestigeStore.ts to fix the doPrestige return type mismatch.

Starting work on #48. Reading prestigeStore.ts to fix the doPrestige return type mismatch.
Anexim commented 2026-05-18 19:51:56 +02:00
Author
Owner
Copy Link
Copy Source

Fixed. Changed the PrestigeState interface declaration from doPrestige: (id: string) => void to doPrestige: (id: string) => boolean to match the actual implementation which returns false on failure and true on success.

Fixed. Changed the PrestigeState interface declaration from `doPrestige: (id: string) => void` to `doPrestige: (id: string) => boolean` to match the actual implementation which returns false on failure and true on success.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#48
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?