Anexim/Mana-Loop
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: getUnlockedAttunements filter logic shows inactive-but-unlocked attunements #50

New Issue
Closed
opened 2026-05-18 16:02:34 +02:00 by Anexim · 3 comments
Anexim commented 2026-05-18 16:02:34 +02:00
Owner
Copy Link
Copy Source

Severity: Major

File: src/lib/game/data/attunements.ts (line 100)

Problem: The filter state.active || ATTUNEMENTS_DEF[id]?.unlocked will include attunements that are inactive but unlocked by default (like enchanter). The function is named getUnlockedAttunements but the filter logic mixes "active" with "unlocked by default" — an inactive-but-unlocked attunement would be included even though the player hasn't activated it.

Impact: UI may show attunements the player hasn't chosen yet, confusing the player and potentially breaking attunement selection flows.

Fix: Change the filter to only include active attunements:

.filter(([id, state]) => state.active)

Or if the intent is to show both active and available-to-activate attunements, rename the function and document the behavior clearly.

**Severity:** Major **File:** `src/lib/game/data/attunements.ts` (line 100) **Problem:** The filter `state.active || ATTUNEMENTS_DEF[id]?.unlocked` will include attunements that are **inactive but unlocked by default** (like `enchanter`). The function is named `getUnlockedAttunements` but the filter logic mixes "active" with "unlocked by default" — an inactive-but-unlocked attunement would be included even though the player hasn't activated it. **Impact:** UI may show attunements the player hasn't chosen yet, confusing the player and potentially breaking attunement selection flows. **Fix:** Change the filter to only include active attunements: ```ts .filter(([id, state]) => state.active) ``` Or if the intent is to show both active and available-to-activate attunements, rename the function and document the behavior clearly.
Anexim added the ai:todo label 2026-05-18 16:02:34 +02:00
n8n-gitea was assigned by Anexim 2026-05-18 16:02:34 +02:00
Anexim commented 2026-05-18 17:10:43 +02:00
Author
Owner
Copy Link
Copy Source

[priority: 4] BROKEN FEATURE — getUnlockedAttunements filter logic shows inactive-but-unlocked attunements.

[priority: 4] BROKEN FEATURE — getUnlockedAttunements filter logic shows inactive-but-unlocked attunements.
Anexim commented 2026-05-18 19:47:23 +02:00
Author
Owner
Copy Link
Copy Source

Starting work on #50. Reading attunements.ts to understand the filter logic bug.

Starting work on #50. Reading attunements.ts to understand the filter logic bug.
Anexim commented 2026-05-18 19:51:55 +02:00
Author
Owner
Copy Link
Copy Source

Fixed. Changed the filter in getUnlockedAttunements from state.active || ATTUNEMENTS_DEF[id]?.unlocked to just state.active. This ensures only actively selected attunements are returned, not ones that are merely unlocked by default.

Fixed. Changed the filter in getUnlockedAttunements from `state.active || ATTUNEMENTS_DEF[id]?.unlocked` to just `state.active`. This ensures only actively selected attunements are returned, not ones that are merely unlocked by default.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#50
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?