99a5f498c0
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m20s
Defense-in-depth fix across 2 files:
1. combat-descent-actions.ts: Added castProgress: 0 and weaponCastProgress: {}
to the isDescentComplete set() call so the meter resets immediately.
2. combat-actions.ts: Added isDescentComplete to the early-exit guard in
processCombatTick so combat processing stops entirely once descent is
complete, preventing phantom spell casts from stale castProgress values.
All 1196 tests pass.
14 lines
776 B
Plaintext
14 lines
776 B
Plaintext
# Circular Dependencies
|
|
Generated: 2026-06-12T17:00:42.616Z
|
|
Found: 4 circular chain(s) — these MUST be fixed before modifying involved files.
|
|
|
|
1. 1) data/guardian-encounters.ts > data/guardian-procedural.ts
|
|
2. 2) stores/golem-combat-actions.ts > stores/golem-combat-helpers.ts
|
|
3. 3) stores/attunementStore.ts > stores/combatStore.ts > stores/combat-descent-actions.ts
|
|
4. 4) stores/attunementStore.ts > stores/combatStore.ts > stores/combat-descent-actions.ts > stores/non-combat-room-actions.ts
|
|
|
|
## How to fix
|
|
1. Identify which import in the chain can be extracted to a shared types/utils file.
|
|
2. Move the shared type or function there.
|
|
3. Both files import from the new shared module instead of each other.
|
|
4. Run: bunx madge --circular src/lib/game (should return clean) |