fix: resolve 5 bugs — missing import, infinite render loop, stale closures, discipline XP

- #249: Add missing getAllGuardianFloors import to SpireSummaryTab.tsx
- #250/#252: Add useRef guard in SpireCombatPage useEffect to prevent infinite re-render loop
- #251: Fix stale closure in PactDebugSection signAllPacts/forcePact — read signedPacts from store.getState()
- #253: Fix DisciplineDebugSection handleAddXP to update totalXP and concurrentLimit
- #252: Marked duplicate of #250

.gitignore

@@ -50,3 +50,4 @@ server.log
 # Skills directory
 .desloppify/
 test-results/
+playwright-report/

docs/circular-deps.txt

@@ -1,4 +1,4 @@
 # Circular Dependencies
-Generated: 2026-06-01T10:58:05.599Z
+Generated: 2026-06-02T08:49:51.414Z
 
 No circular dependencies found. ✅

docs/dependency-graph.json

@@ -1,6 +1,6 @@
 {
   "_meta": {
-    "generated": "2026-06-01T10:58:03.834Z",
+    "generated": "2026-06-02T08:49:49.529Z",
     "description": "Import dependency graph for src/lib/game. Keys are files, values are arrays of files they import.",
     "usage": "To find what a file affects, search for its path in the VALUES. To find what a file depends on, look at its KEY entry."
   },
@@ -586,6 +586,16 @@
       "types.ts",
       "types/equipmentSlot.ts"
     ],
+    "stores/debugBridge.ts": [
+      "stores/attunementStore.ts",
+      "stores/combatStore.ts",
+      "stores/craftingStore.ts",
+      "stores/discipline-slice.ts",
+      "stores/gameStore.ts",
+      "stores/manaStore.ts",
+      "stores/prestigeStore.ts",
+      "stores/uiStore.ts"
+    ],
     "stores/discipline-slice.ts": [
       "data/disciplines/base.ts",
       "data/disciplines/elemental-regen-advanced.ts",

docs/project-structure.txt

@@ -19,10 +19,6 @@ Mana-Loop/
 │   ├── enchanter-happy-path.spec.ts
 │   ├── fabricator-happy-path.spec.ts
 │   └── playtest.spec.ts
-├── playwright-report/
-│   ├── data/
-│   │   └── 199a0ed84e7318aab410b0ec2f96ea8f6478a4da.png
-│   └── index.html
 ├── public/
 │   ├── fonts/
 │   │   ├── GeistMonoVF.woff

src/components/game/tabs/DebugTab/DisciplineDebugSection.tsx

@@ -4,6 +4,7 @@ import { Button } from '@/components/ui/button';
 import { Card, CardContent, CardHeader, CardTitle } from '@/components/ui/card';
 import { BookOpen, Plus, Pause, Play } from 'lucide-react';
 import { useDisciplineStore } from '@/lib/game/stores/discipline-slice';
+import { MAX_CONCURRENT_DISCIPLINES } from '@/lib/game/types/disciplines';
 import { ALL_DISCIPLINES } from '@/lib/game/data/disciplines';
 import { useManaStore } from '@/lib/game/stores/manaStore';
 import { DebugName } from '@/components/game/debug/debug-context';
@@ -32,11 +33,18 @@ export function DisciplineDebugSection() {
     useDisciplineStore.setState((s) => {
       const disc = s.disciplines[id];
       if (!disc) return s;
+      const newTotalXP = s.totalXP + amount;
+      const newLimit = Math.min(
+        MAX_CONCURRENT_DISCIPLINES + Math.floor(newTotalXP / 500),
+        MAX_CONCURRENT_DISCIPLINES + 3,
+      );
       return {
         disciplines: {
           ...s.disciplines,
           [id]: { ...disc, xp: disc.xp + amount },
         },
+        totalXP: newTotalXP,
+        concurrentLimit: Math.max(s.concurrentLimit, newLimit),
       };
     });
   };

src/components/game/tabs/DebugTab/GameStateDebugSection.tsx

@@ -167,8 +167,9 @@ function TimeControlSection({ day, hour, paused, onSetDay, onTogglePause }: {
 
 // ─── Quick Actions Section ───────────────────────────────────────────────────
 
-function QuickActionsSection({ onUnlockBase }: {
+function QuickActionsSection({ onUnlockBase, onAddStarterMaterials }: {
   onUnlockBase: () => void;
+  onAddStarterMaterials: () => void;
 }) {
   return (
     <Card className="bg-gray-900/80 border-gray-700">
@@ -183,6 +184,9 @@ function QuickActionsSection({ onUnlockBase }: {
           <Button size="sm" variant="outline" onClick={onUnlockBase}>
             Unlock All Base Elements
           </Button>
+          <Button size="sm" variant="outline" onClick={onAddStarterMaterials}>
+            Add Starter Materials
+          </Button>
         </div>
       </CardContent>
     </Card>
@@ -248,6 +252,21 @@ export function GameStateDebugSection() {
     });
   };
 
+  const handleAddStarterMaterials = () => {
+    useCraftingStore.setState((s) => ({
+      lootInventory: {
+        ...s.lootInventory,
+        materials: {
+          ...s.lootInventory.materials,
+          manaCrystalDust: (s.lootInventory.materials.manaCrystalDust || 0) + 20,
+          earthShard: (s.lootInventory.materials.earthShard || 0) + 10,
+          metalShard: (s.lootInventory.materials.metalShard || 0) + 5,
+          elementalCore: (s.lootInventory.materials.elementalCore || 0) + 3,
+        },
+      },
+    }));
+  };
+
   return (
     <DebugName name="GameStateDebugSection">
       <div className="space-y-4">
@@ -259,6 +278,7 @@ export function GameStateDebugSection() {
           <TimeControlSection day={day} hour={hour} paused={paused} onSetDay={handleSetDay} onTogglePause={togglePause} />
           <QuickActionsSection
             onUnlockBase={handleUnlockBase}
+            onAddStarterMaterials={handleAddStarterMaterials}
           />
         </div>
       </div>

src/components/game/tabs/DebugTab/PactDebugSection.tsx

@@ -71,13 +71,16 @@ export function PactDebugSection() {
     const guardian = getGuardianForFloor(floor);
     if (!guardian) return;
 
-    if (signedPacts.includes(floor)) {
+    // Always read fresh state from store to avoid stale closures
+    const currentSignedPacts = usePrestigeStore.getState().signedPacts;
+    const maxPacts = 1 + (prestigeUpgrades?.pactCapacity || 0);
+
+    if (currentSignedPacts.includes(floor)) {
       addLog(`⚠️ Already signed pact with ${guardian.name}!`);
       return;
     }
 
-    const maxPacts = 1 + (prestigeUpgrades?.pactCapacity || 0);
+    if (currentSignedPacts.length >= maxPacts) {
-    if (signedPacts.length >= maxPacts) {
       addLog(`⚠️ Cannot sign more pacts! Maximum: ${maxPacts}.`);
       return;
     }
@@ -111,8 +114,14 @@ export function PactDebugSection() {
   };
 
   const signAllPacts = () => {
+    const maxPacts = 1 + (prestigeUpgrades?.pactCapacity || 0);
     guardianFloors.forEach((floor) => {
-      if (!signedPacts.includes(floor)) {
+      // Read fresh state from store to avoid stale closure bug:
+      // signedPacts from render-time closure is always the initial value
+      // during the loop, so the maxPacts check never triggers.
+      const currentSigned = usePrestigeStore.getState().signedPacts;
+      if (currentSigned.length >= maxPacts) return;
+      if (!currentSigned.includes(floor)) {
         forcePact(floor);
       }
     });

src/components/game/tabs/SpireCombatPage/SpireCombatPage.tsx

@@ -1,6 +1,6 @@
 'use client';
 
-import { useState, useEffect, useMemo } from 'react';
+import { useState, useEffect, useMemo, useRef } from 'react';
 import { useShallow } from 'zustand/react/shallow';
 import { useCombatStore, useManaStore, usePrestigeStore, fmt, computeMaxMana, computeRegen } from '@/lib/game/stores';
 import { computeDisciplineEffects } from '@/lib/game/effects/discipline-effects';
@@ -127,7 +127,15 @@ export function SpireCombatPage() {
     return base + floorBonus + randomVariation;
   }, [currentFloor, seededRandom]);
 
+  // Track the last floor+totalRooms combo we generated a room for.
+  // Prevents infinite re-render loop: without this guard, the effect
+  // fires → setCurrentRoom → store update → re-render → tick advances
+  // currentFloor → effect fires → ... (loop).
+  const lastGeneratedRef = useRef<string | null>(null);
   useEffect(() => {
+    const key = `${currentFloor}:${totalRooms}`;
+    if (lastGeneratedRef.current === key) return; // already generated
+    lastGeneratedRef.current = key;
     setRoomsCleared(0);
     const newRoom = generateSpireFloorState(currentFloor, 0, totalRooms);
     setCurrentRoom(newRoom);

src/components/game/tabs/SpireSummaryTab.tsx

@@ -4,7 +4,7 @@ import { useMemo } from 'react';
 import { useShallow } from 'zustand/react/shallow';
 import { useCombatStore, usePrestigeStore } from '@/lib/game/stores';
 import { FLOOR_ELEM_CYCLE } from '@/lib/game/constants';
-import { getGuardianForFloor } from '@/lib/game/data/guardian-encounters';
+import { getGuardianForFloor, getAllGuardianFloors } from '@/lib/game/data/guardian-encounters';
 import { Card, CardContent } from '@/components/ui/card';
 import { Badge } from '@/components/ui/badge';
 import { ScrollArea } from '@/components/ui/scroll-area';