Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Bug: Game state completely resets on page refresh #147

New Issue
Closed
opened 2026-05-27 10:22:52 +02:00 by Anexim · 2 comments
Anexim commented 2026-05-27 10:22:52 +02:00
Owner
Copy Link
Copy Source

Bug Description

Refreshing the browser page completely resets the game state — all progress is lost.

Root Cause Analysis

The persistence infrastructure uses Zustand's persist middleware with createSafeStorage() across 8 stores. Multiple issues contribute:

Critical: Silent setItem failure

src/lib/game/utils/safe-persist.ts lines 30-34: The setItem method has an empty catch block — ALL errors (quota exceeded, serialization failure, private browsing) are silently swallowed, so the game silently never saves.

High: Missing version field

No persist config includes a version field, so schema changes silently break rehydration.

Medium: Missing state fields in partialize

  • manaStore.ts: meditateTicks not persisted (line 208)
  • combatStore.ts: currentAction, currentRoom, comboHitCount, floorHitCount, totalSpellsCast, totalDamageDealt, totalCraftsCompleted not persisted (lines 310-321)

Fix Required

  1. Add error logging to setItem in safe-persist.ts: console.error('[safe-persist] Failed to persist:', name, error)
  2. Add version: 1 to all 8 store persist configs
  3. Add missing fields to partialize in manaStore.ts and combatStore.ts

Affected Files

  • src/lib/game/utils/safe-persist.ts (line 30-34)
  • src/lib/game/stores/manaStore.ts (line 206-208)
  • src/lib/game/stores/combatStore.ts (line 308-321)
  • All store files for version field addition
## Bug Description Refreshing the browser page completely resets the game state — all progress is lost. ## Root Cause Analysis The persistence infrastructure uses Zustand's `persist` middleware with `createSafeStorage()` across 8 stores. Multiple issues contribute: ### Critical: Silent `setItem` failure `src/lib/game/utils/safe-persist.ts` lines 30-34: The `setItem` method has an empty catch block — ALL errors (quota exceeded, serialization failure, private browsing) are silently swallowed, so the game silently never saves. ### High: Missing `version` field No persist config includes a `version` field, so schema changes silently break rehydration. ### Medium: Missing state fields in `partialize` - `manaStore.ts`: `meditateTicks` not persisted (line 208) - `combatStore.ts`: `currentAction`, `currentRoom`, `comboHitCount`, `floorHitCount`, `totalSpellsCast`, `totalDamageDealt`, `totalCraftsCompleted` not persisted (lines 310-321) ## Fix Required 1. Add error logging to `setItem` in `safe-persist.ts`: `console.error('[safe-persist] Failed to persist:', name, error)` 2. Add `version: 1` to all 8 store persist configs 3. Add missing fields to `partialize` in `manaStore.ts` and `combatStore.ts` ## Affected Files - `src/lib/game/utils/safe-persist.ts` (line 30-34) - `src/lib/game/stores/manaStore.ts` (line 206-208) - `src/lib/game/stores/combatStore.ts` (line 308-321) - All store files for `version` field addition
Anexim added the ai:todo label 2026-05-27 10:22:52 +02:00
n8n-gitea was assigned by Anexim 2026-05-27 10:22:52 +02:00
Anexim commented 2026-05-27 10:43:01 +02:00
Author
Owner
Copy Link
Copy Source

Starting work on #147 — Game state resets on page refresh. Will investigate safe-persist.ts, manaStore.ts, combatStore.ts, and add version fields to all store persist configs.

Starting work on #147 — Game state resets on page refresh. Will investigate safe-persist.ts, manaStore.ts, combatStore.ts, and add version fields to all store persist configs.
Anexim commented 2026-05-27 10:46:01 +02:00
Author
Owner
Copy Link
Copy Source

Fixed #147 — Game state no longer resets silently on refresh.

Changes:

  1. safe-persist.ts: Added console.error logging to setItem catch block (was silently swallowing all errors)
  2. manaStore.ts: Added meditateTicks to partialize (was lost on refresh)
  3. combatStore.ts: Added currentAction, currentRoom, comboHitCount, floorHitCount, totalSpellsCast, totalDamageDealt, totalCraftsCompleted to partialize
  4. All 8 stores: Added version: 1 to persist configs for future schema migration safety

All 885 tests pass. Committed and pushed as 707a1ee.

Fixed #147 — Game state no longer resets silently on refresh. Changes: 1. safe-persist.ts: Added console.error logging to setItem catch block (was silently swallowing all errors) 2. manaStore.ts: Added meditateTicks to partialize (was lost on refresh) 3. combatStore.ts: Added currentAction, currentRoom, comboHitCount, floorHitCount, totalSpellsCast, totalDamageDealt, totalCraftsCompleted to partialize 4. All 8 stores: Added version: 1 to persist configs for future schema migration safety All 885 tests pass. Committed and pushed as 707a1ee.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#147
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?