Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Task: Audit and fix all discipline names and descriptions #148

New Issue
Closed
opened 2026-05-27 10:22:52 +02:00 by Anexim · 2 comments
Anexim commented 2026-05-27 10:22:52 +02:00
Owner
Copy Link
Copy Source

Description

Many disciplines have names or descriptions that don't match their actual effects. A full audit of all disciplines is needed.

Disciplines Requiring Description Fixes

Elemental Attunement (all 7 elements)

File: src/lib/game/data/disciplines/elemental.ts line 39

  • All 7 (Fire, Water, Air, Earth, Light, Dark, Attunement) have description: "Begin focusing raw mana into <element>." — this describes mana conversion
  • Actual effect: stat: elementCap_<type> — increases mana capacity
  • Fix: Change to something like "Increase your <element> mana capacity." or "Acclimatize your body to hold more <element> mana."

Mana Channeling (Enchanter)

File: src/lib/game/data/disciplines/enchanter.ts line 38

  • Description: "Use lightning to transfer mana to equipment."
  • Actual effect: stat: 'clickManaMultiplier' — increases mana per click
  • Fix: Change to describe click mana improvement, e.g. "Improve your ability to channel mana through manual focus."

All Other Discipline Descriptions — Verification Needed

Every discipline description across all data files should be reviewed against its actual statBonus.stat effect:

  • src/lib/game/data/disciplines/base.ts
  • src/lib/game/data/disciplines/elemental-regen.ts
  • src/lib/game/data/disciplines/elemental-regen-advanced.ts
  • src/lib/game/data/disciplines/enchanter-utility.ts
  • src/lib/game/data/disciplines/enchanter-spells.ts
  • src/lib/game/data/disciplines/enchanter-special.ts
  • src/lib/game/data/disciplines/invoker.ts
  • src/lib/game/data/disciplines/fabricator.ts

Reference

See src/lib/game/effects/discipline-effects.ts → computeDisciplineEffects() for what each statBonus.stat key actually does.

## Description Many disciplines have names or descriptions that don't match their actual effects. A full audit of all disciplines is needed. ## Disciplines Requiring Description Fixes ### Elemental Attunement (all 7 elements) **File:** `src/lib/game/data/disciplines/elemental.ts` line 39 - All 7 (Fire, Water, Air, Earth, Light, Dark, Attunement) have description: `"Begin focusing raw mana into <element>."` — this describes mana *conversion* - **Actual effect:** `stat: elementCap_<type>` — increases mana *capacity* - **Fix:** Change to something like `"Increase your <element> mana capacity."` or `"Acclimatize your body to hold more <element> mana."` ### Mana Channeling (Enchanter) **File:** `src/lib/game/data/disciplines/enchanter.ts` line 38 - **Description:** `"Use lightning to transfer mana to equipment."` - **Actual effect:** `stat: 'clickManaMultiplier'` — increases mana per click - **Fix:** Change to describe click mana improvement, e.g. `"Improve your ability to channel mana through manual focus."` ## All Other Discipline Descriptions — Verification Needed Every discipline description across all data files should be reviewed against its actual `statBonus.stat` effect: - `src/lib/game/data/disciplines/base.ts` - `src/lib/game/data/disciplines/elemental-regen.ts` - `src/lib/game/data/disciplines/elemental-regen-advanced.ts` - `src/lib/game/data/disciplines/enchanter-utility.ts` - `src/lib/game/data/disciplines/enchanter-spells.ts` - `src/lib/game/data/disciplines/enchanter-special.ts` - `src/lib/game/data/disciplines/invoker.ts` - `src/lib/game/data/disciplines/fabricator.ts` ## Reference See `src/lib/game/effects/discipline-effects.ts` → `computeDisciplineEffects()` for what each `statBonus.stat` key actually does.
Anexim added the ai:todo label 2026-05-27 10:22:52 +02:00
n8n-gitea was assigned by Anexim 2026-05-27 10:22:52 +02:00
Anexim commented 2026-05-27 12:05:09 +02:00
Author
Owner
Copy Link
Copy Source

Starting work on #148 — Audit and fix all discipline names and descriptions. Will review every discipline's description against its actual statBonus.stat effect.

Starting work on #148 — Audit and fix all discipline names and descriptions. Will review every discipline's description against its actual `statBonus.stat` effect.
Anexim commented 2026-05-27 12:15:39 +02:00
Author
Owner
Copy Link
Copy Source

Fixed #148 — Audited and fixed all discipline descriptions to match their actual effects.

Changes:

  • elemental.ts: Changed "Begin focusing raw mana into X" → "Increase your X mana capacity." (all 7 elements)
  • enchanter.ts: Changed "Channel transference mana to imbue equipment" → "Improve your ability to channel mana through manual focus." (Mana Channeling, stat: clickManaMultiplier)
  • enchanter.ts: Changed "Improve your ability to apply enchantments" → "Boost your enchantment power, making all enchantments more effective." (Enchantment Crafting)
  • enchanter-utility.ts: Changed "Learn to enchant equipment with utility effects" → "Increase your study speed, unlocking utility enchantments faster." (stat: studySpeed)
  • enchanter-utility.ts: Changed "Learn to enchant equipment with mana-boosting effects" → "Increase your max mana, unlocking mana enchantments for equipment." (stat: maxMana)

All 902 tests pass. Committed and pushed as a47d656.

Fixed #148 — Audited and fixed all discipline descriptions to match their actual effects. **Changes:** - `elemental.ts`: Changed "Begin focusing raw mana into X" → "Increase your X mana capacity." (all 7 elements) - `enchanter.ts`: Changed "Channel transference mana to imbue equipment" → "Improve your ability to channel mana through manual focus." (Mana Channeling, stat: clickManaMultiplier) - `enchanter.ts`: Changed "Improve your ability to apply enchantments" → "Boost your enchantment power, making all enchantments more effective." (Enchantment Crafting) - `enchanter-utility.ts`: Changed "Learn to enchant equipment with utility effects" → "Increase your study speed, unlocking utility enchantments faster." (stat: studySpeed) - `enchanter-utility.ts`: Changed "Learn to enchant equipment with mana-boosting effects" → "Increase your max mana, unlocking mana enchantments for equipment." (stat: maxMana) All 902 tests pass. Committed and pushed as a47d656.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#148
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?