Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Bug: Two-handed weapons allow off-hand slot selection in Equipment tab #152

New Issue
Closed
opened 2026-05-27 10:22:54 +02:00 by Anexim · 2 comments
Anexim commented 2026-05-27 10:22:54 +02:00
Owner
Copy Link
Copy Source

Bug Description

When equipping a two-handed weapon like a staff, the Equipment tab shows a slot selector dropdown offering both "mainHand" and "offHand". Only "mainHand" should be a valid target for a two-handed weapon. Selecting off-hand silently fails.

Root Cause

In src/lib/game/data/equipment/utils.ts lines 48-56, the getValidSlotsForEquipmentType function returns ['mainHand', 'offHand'] for two-handed weapons, when it should only return ['mainHand'].

The underlying equip logic in crafting-utils.ts and equipment-actions.ts correctly blocks equipping a two-handed weapon in the off-hand, but the UI is misleading by presenting it as an option.

Fix Required

Change line 50 in utils.ts from return ['mainHand', 'offHand'] to return ['mainHand'].

Affected Files

  • src/lib/game/data/equipment/utils.ts line 50
  • src/components/game/tabs/EquipmentTab/InventoryList.tsx lines 47, 99 (downstream consumer — no code change needed if utils.ts is fixed)
## Bug Description When equipping a two-handed weapon like a staff, the Equipment tab shows a slot selector dropdown offering both "mainHand" and "offHand". Only "mainHand" should be a valid target for a two-handed weapon. Selecting off-hand silently fails. ## Root Cause In `src/lib/game/data/equipment/utils.ts` lines 48-56, the `getValidSlotsForEquipmentType` function returns `['mainHand', 'offHand']` for two-handed weapons, when it should only return `['mainHand']`. The underlying equip logic in `crafting-utils.ts` and `equipment-actions.ts` correctly blocks equipping a two-handed weapon in the off-hand, but the UI is misleading by presenting it as an option. ## Fix Required Change line 50 in `utils.ts` from `return ['mainHand', 'offHand']` to `return ['mainHand']`. ## Affected Files - `src/lib/game/data/equipment/utils.ts` line 50 - `src/components/game/tabs/EquipmentTab/InventoryList.tsx` lines 47, 99 (downstream consumer — no code change needed if utils.ts is fixed)
Anexim added the ai:todo label 2026-05-27 10:22:54 +02:00
n8n-gitea was assigned by Anexim 2026-05-27 10:22:54 +02:00
Anexim commented 2026-05-27 11:38:59 +02:00
Author
Owner
Copy Link
Copy Source

Starting work on #152 — Two-handed weapons allow off-hand slot selection in Equipment tab. Will fix the getValidSlotsForEquipmentType function in utils.ts.

Starting work on #152 — Two-handed weapons allow off-hand slot selection in Equipment tab. Will fix the `getValidSlotsForEquipmentType` function in `utils.ts`.
Anexim commented 2026-05-27 11:41:01 +02:00
Author
Owner
Copy Link
Copy Source

Fixed #152 — Two-handed weapons no longer show off-hand slot option.

Root cause: getValidSlotsForEquipmentType in utils.ts returned ['mainHand', 'offHand'] for two-handed weapons, but they should only be equipable in mainHand (since they occupy both hands).

Fix: Changed to return ['mainHand'] for two-handed weapons. Updated comment for clarity.

All 902 tests pass. Committed and pushed as 428d308.

Fixed #152 — Two-handed weapons no longer show off-hand slot option. **Root cause**: `getValidSlotsForEquipmentType` in `utils.ts` returned `['mainHand', 'offHand']` for two-handed weapons, but they should only be equipable in mainHand (since they occupy both hands). **Fix**: Changed to return `['mainHand']` for two-handed weapons. Updated comment for clarity. All 902 tests pass. Committed and pushed as 428d308.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#152
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?