Anexim/Mana-Loop
1
1
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Task: GolemancyTab text fixes — expand abbreviations and show special properties #154

New Issue
Closed
opened 2026-05-27 10:22:55 +02:00 by Anexim · 2 comments
Anexim commented 2026-05-27 10:22:55 +02:00
Owner
Copy Link
Copy Source

Description

The GolemancyTab displays abbreviated stat names and doesn't list special golem properties.

Issues

Abbreviations to Expand

In src/components/game/tabs/GolemancyTab.tsx:

  • Line 130: DMG: → Damage:
  • Line 133: SPD: → Attack Speed:
  • Line 139: AP: → Armor Pierce:

Missing Special Properties

The GolemDef type in src/lib/game/data/golems/types.ts has no field for special abilities. The following golems have implied special properties that should be tracked and displayed:

Golem Implied Special Property Description Source
Lava Golem Burns enemies over time (DOT) hybrid-golems.ts:18
Galvanic Golem Extremely fast attacks bonus hybrid-golems.ts:34
Prism Golem Channels light into piercing beams hybrid-golems.ts:84
Quicksilver Golem Flows around defenses, fast & hard to dodge hybrid-golems.ts:100
Voidstone Golem Earth infused with void energy hybrid-golems.ts:118
Obsidian Golem Devastating single-target damage hybrid-golems.ts:68
Sand Golem Hits multiple enemies (AoE) — already handled via isAoe elemental-golems.ts:55

Fix Required

  1. Add a specialAbilities field (array of { name: string, description: string }) to GolemDef type in types.ts
  2. Populate it in the golem data files
  3. Update GolemCard in GolemancyTab.tsx to render the special abilities section
  4. Fix the three abbreviations (DMG→Damage, SPD→Attack Speed, AP→Armor Pierce)

Affected Files

  • src/lib/game/data/golems/types.ts — add field to interface
  • src/lib/game/data/golems/hybrid-golems.ts — add special abilities data
  • src/lib/game/data/golems/elemental-golems.ts — add special abilities data
  • src/components/game/tabs/GolemancyTab.tsx — fix abbreviations + render special abilities
## Description The GolemancyTab displays abbreviated stat names and doesn't list special golem properties. ## Issues ### Abbreviations to Expand In `src/components/game/tabs/GolemancyTab.tsx`: - Line 130: `DMG:` → `Damage:` - Line 133: `SPD:` → `Attack Speed:` - Line 139: `AP:` → `Armor Pierce:` ### Missing Special Properties The `GolemDef` type in `src/lib/game/data/golems/types.ts` has **no field** for special abilities. The following golems have implied special properties that should be tracked and displayed: | Golem | Implied Special Property | Description Source | |-------|-------------------------|-------------------| | Lava Golem | Burns enemies over time (DOT) | `hybrid-golems.ts:18` | | Galvanic Golem | Extremely fast attacks bonus | `hybrid-golems.ts:34` | | Prism Golem | Channels light into piercing beams | `hybrid-golems.ts:84` | | Quicksilver Golem | Flows around defenses, fast & hard to dodge | `hybrid-golems.ts:100` | | Voidstone Golem | Earth infused with void energy | `hybrid-golems.ts:118` | | Obsidian Golem | Devastating single-target damage | `hybrid-golems.ts:68` | | Sand Golem | Hits multiple enemies (AoE) — already handled via `isAoe` | `elemental-golems.ts:55` | ## Fix Required 1. Add a `specialAbilities` field (array of `{ name: string, description: string }`) to `GolemDef` type in `types.ts` 2. Populate it in the golem data files 3. Update `GolemCard` in `GolemancyTab.tsx` to render the special abilities section 4. Fix the three abbreviations (DMG→Damage, SPD→Attack Speed, AP→Armor Pierce) ## Affected Files - `src/lib/game/data/golems/types.ts` — add field to interface - `src/lib/game/data/golems/hybrid-golems.ts` — add special abilities data - `src/lib/game/data/golems/elemental-golems.ts` — add special abilities data - `src/components/game/tabs/GolemancyTab.tsx` — fix abbreviations + render special abilities
Anexim added the ai:todo label 2026-05-27 10:22:55 +02:00
n8n-gitea was assigned by Anexim 2026-05-27 10:22:55 +02:00
Anexim commented 2026-05-27 12:16:43 +02:00
Author
Owner
Copy Link
Copy Source

Starting work on #154 — GolemancyTab text fixes. Will: 1) Add specialAbilities field to GolemDef type, 2) Populate special abilities in golem data files, 3) Update GolemancyTab to render them, 4) Fix abbreviations.

Starting work on #154 — GolemancyTab text fixes. Will: 1) Add specialAbilities field to GolemDef type, 2) Populate special abilities in golem data files, 3) Update GolemancyTab to render them, 4) Fix abbreviations.
Anexim commented 2026-05-27 12:21:07 +02:00
Author
Owner
Copy Link
Copy Source

Fixed #154 — GolemancyTab text fixes complete.

Changes:

  • types.ts: Added specialAbilities?: { name: string; description: string }[] to GolemDef
  • hybrid-golems.ts: Added special abilities to all 6 hybrid golems (Lava: Burn, Galvanic: Lightning Speed, Obsidian: Devastating Strike, Prism: Piercing Beams, Quicksilver: Flow, Voidstone: Void Infusion)
  • elemental-golems.ts: Added special ability to Sand Golem (Sandstorm AoE)
  • GolemancyTab.tsx: Fixed DMG→Damage, SPD→Attack Speed, AP→Armor Pierce; added special abilities rendering section

All 902 tests pass. Committed and pushed as badd233.

Fixed #154 — GolemancyTab text fixes complete. **Changes:** - `types.ts`: Added `specialAbilities?: { name: string; description: string }[]` to `GolemDef` - `hybrid-golems.ts`: Added special abilities to all 6 hybrid golems (Lava: Burn, Galvanic: Lightning Speed, Obsidian: Devastating Strike, Prism: Piercing Beams, Quicksilver: Flow, Voidstone: Void Infusion) - `elemental-golems.ts`: Added special ability to Sand Golem (Sandstorm AoE) - `GolemancyTab.tsx`: Fixed DMG→Damage, SPD→Attack Speed, AP→Armor Pierce; added special abilities rendering section All 902 tests pass. Committed and pushed as badd233.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai:blocked
ai:done
ai:in-progress
ai:priority:high
priority
 ai:review
ai:todo
No Label ai:todo
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
n8n-gitea zhipu Anexim
No Assignees n8n-gitea
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anexim/Mana-Loop#154
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?