fix: Bug fixes #218 #222 #220 #223 #215 #216 - attunement free mana, transference circular ref, guardian defeat tracking, discipline negative mana, guardian data, crafting refunds

src/lib/game/stores/gameStore.ts

@@ -2,8 +2,6 @@
 import { create } from 'zustand';
 import { persist } from 'zustand/middleware';
 import { HOURS_PER_TICK, MAX_DAY } from '../constants';
-import { getGuardianForFloor } from '../data/guardian-encounters';
-import { hasSpecial, SPECIAL_EFFECTS } from '../effects/special-effects';
 import { computeEquipmentEffects } from '../effects';
 import type { ComputedEffects } from '../effects/upgrade-effects.types';
 
@@ -11,6 +9,7 @@ import { computeDisciplineEffects } from '../effects/discipline-effects';
 import { computeMaxMana, computeRegen, getMeditationBonus, getIncursionStrength, calcInsight } from '../utils';
 import { mergePerElementCapBonuses } from '../utils/element-cap-bonus';
 import { processPactRitual } from './pipelines/pact-ritual';
+import { buildCombatCallbacks } from './pipelines/combat-tick';
 import { useUIStore } from './uiStore';
 import { usePrestigeStore } from './prestigeStore';
 import { useManaStore } from './manaStore';
@@ -158,6 +157,7 @@ export const useGameStore = create<GameCoordinatorStore>()(
           }
 
           let totalConversionPerTick = 0;
+          let rawManaDelta = 0;
           let elements = { ...ctx.mana.elements };
           Object.entries(ctx.attunement.attunements).forEach(([id, state]) => {
             if (!state.active) return;
@@ -166,6 +166,8 @@ export const useGameStore = create<GameCoordinatorStore>()(
             const scaledRate = getAttunementConversionRate(id, state.level || 1);
             const conversionThisTick = scaledRate * HOURS_PER_TICK;
             totalConversionPerTick += conversionThisTick;
+            // Deduct raw mana to pay for the conversion — without this, attunements produce free element mana
+            rawManaDelta -= conversionThisTick;
             if (elements[def.primaryManaType]) {
               if (!elements[def.primaryManaType].unlocked) {
                 elements[def.primaryManaType] = { ...elements[def.primaryManaType], unlocked: true };
@@ -179,7 +181,8 @@ export const useGameStore = create<GameCoordinatorStore>()(
 
           const effectiveRegen = Math.max(0, baseRegen * (1 - incursionStrength) * meditationMultiplier - totalConversionPerTick);
 
-          let rawMana = Math.min(ctx.mana.rawMana + effectiveRegen * HOURS_PER_TICK, maxMana);
+          const rawAfterConversion = ctx.mana.rawMana + rawManaDelta;
+          let rawMana = Math.max(0, Math.min(rawAfterConversion + effectiveRegen * HOURS_PER_TICK, maxMana));
           let totalManaGathered = ctx.mana.totalManaGathered;
 
           if (ctx.combat.currentAction === 'convert') {
@@ -221,11 +224,18 @@ export const useGameStore = create<GameCoordinatorStore>()(
               }
             }
             if (!canConvert) continue;
+            // Re-check against actual remaining mana to prevent negative values
+            // when multiple disciplines share the same source
+            for (const srcType of conv.sourceManaTypes) {
+              if (srcType === 'raw' && rawMana < conversionAmount) { canConvert = false; break; }
+              if (srcType !== 'raw' && elements[srcType] && elements[srcType].current < conversionAmount) { canConvert = false; break; }
+            }
+            if (!canConvert) continue;
             for (const srcType of conv.sourceManaTypes) {
               if (srcType === 'raw') {
                 rawMana -= conversionAmount;
               } else if (elements[srcType]) {
-                elements[srcType] = { ...elements[srcType], current: elements[srcType].current - conversionAmount };
+                elements[srcType] = { ...elements[srcType], current: Math.max(0, elements[srcType].current - conversionAmount) };
               }
             }
             if (elements[targetElem]) {
@@ -263,81 +273,22 @@ export const useGameStore = create<GameCoordinatorStore>()(
 
           // Combat — delegate to combatStore
           if (ctx.combat.currentAction === 'climb') {
+            const combatCbs = buildCombatCallbacks({
+              ctx, effects, maxMana, addLog, useCombatStore, usePrestigeStore,
+            });
             const combatResult = useCombatStore.getState().processCombatTick(
-              rawMana,
-              elements,
-              maxMana,
-              1,
-              (floor, wasGuardian) => {
-                if (wasGuardian) {
-                  const defeatedGuardian = getGuardianForFloor(floor);
-                  addLog((defeatedGuardian?.name || 'Unknown') + ' defeated! Visit the Grimoire to sign a pact.');
-                } else if (floor % 5 === 0) {
-                  addLog('Floor ' + floor + ' cleared!');
-                }
-                useCombatStore.setState({ guardianShield: 0, guardianShieldMax: 0, guardianBarrier: 0, guardianBarrierMax: 0 });
-              },
-              (damage) => {
-                let dmg = damage;
-                if (hasSpecial(effects, SPECIAL_EFFECTS.EXECUTIONER) && ctx.combat.floorHP / ctx.combat.floorMaxHP < 0.25) {
-                  dmg *= 2;
-                }
-                if (hasSpecial(effects, SPECIAL_EFFECTS.BERSERKER) && rawMana < maxMana * 0.5) {
-                  dmg *= 1.5;
-                }
-
-                const guardian = getGuardianForFloor(ctx.combat.currentFloor);
-                if (guardian && (guardian.shield || guardian.barrier || guardian.healthRegen)) {
-                  let shield = ctx.combat.guardianShield;
-                  let shieldMax = ctx.combat.guardianShieldMax;
-                  let barrier = ctx.combat.guardianBarrier;
-                  let barrierMax = ctx.combat.guardianBarrierMax;
-
-                  if (guardian.shieldRegen && shield < shieldMax) {
-                    shield = Math.min(shieldMax, shield + guardian.shieldRegen * HOURS_PER_TICK);
-                  }
-                  if (guardian.barrierRegen && barrier < barrierMax) {
-                    barrier = Math.min(barrierMax, barrier + guardian.barrierRegen * HOURS_PER_TICK);
-                  }
-
-                  if (shield > 0 && dmg > 0) {
-                    const absorb = Math.min(shield, dmg);
-                    shield -= absorb;
-                    dmg -= absorb;
-                  }
-
-                  if (barrier > 0 && dmg > 0) {
-                    dmg *= (1 - barrier);
-                  }
-
-                  if (guardian.healthRegen && guardian.healthRegen > 0) {
-                    const healAmount = guardian.healthRegenIsPercent
-                      ? Math.floor(ctx.combat.floorMaxHP * guardian.healthRegen / 100 * HOURS_PER_TICK)
-                      : Math.floor(guardian.healthRegen * HOURS_PER_TICK);
-                    dmg -= healAmount;
-                  }
-
-                  useCombatStore.setState({
-                    guardianShield: shield,
-                    guardianShieldMax: shieldMax,
-                    guardianBarrier: barrier,
-                    guardianBarrierMax: barrierMax,
-                  });
-                }
-
-                return { rawMana, elements, modifiedDamage: dmg };
-              },
+              rawMana, elements, maxMana, 1,
+              combatCbs.onFloorCleared,
+              combatCbs.makeOnDamageDealt(() => rawMana, () => elements),
               ctx.prestige.signedPacts,
             );
 
             rawMana = combatResult.rawMana;
             elements = combatResult.elements;
             totalManaGathered += combatResult.totalManaGathered || 0;
-
             if (combatResult.logMessages) {
               combatResult.logMessages.forEach(msg => addLog(msg));
             }
-
             writes.combat = {
               ...(writes.combat || {}),
               currentFloor: combatResult.currentFloor,