• Joined on 2025-05-17
Anexim commented on issue Anexim/Mana-Loop#49 2026-05-18 20:58:25 +02:00
chore: uiStore.ts has identical duplicate reset() and resetUI() functions

Fixed: Removed duplicate resetUI() function from uiStore.ts. Updated caller in gameActions.ts to use reset() instead.

Anexim closed issue Anexim/Mana-Loop#34 2026-05-18 20:58:24 +02:00
fix: Missing types import in upgrade-effects.types.ts — build error
Anexim commented on issue Anexim/Mana-Loop#34 2026-05-18 20:58:24 +02:00
fix: Missing types import in upgrade-effects.types.ts — build error

Fixed: Removed dead import of SkillUpgradeChoice/SkillUpgradeEffect from non-existent ./types file in upgrade-effects.types.ts. Replaced with inline string type for the effect field.

Anexim closed issue Anexim/Mana-Loop#35 2026-05-18 20:58:24 +02:00
fix: Enemy healthRegen field is set but never consumed by combat logic
Anexim commented on issue Anexim/Mana-Loop#35 2026-05-18 20:58:24 +02:00
fix: Enemy healthRegen field is set but never consumed by combat logic

Fixed: Removed dead healthRegen field from EnemyState type and all enemy generation in room-utils.ts. Also removed the unused getEnemyHealthRegen function.

Anexim closed issue Anexim/Mana-Loop#49 2026-05-18 20:58:24 +02:00
chore: uiStore.ts has identical duplicate reset() and resetUI() functions
Anexim commented on issue Anexim/Mana-Loop#31 2026-05-18 20:58:23 +02:00
chore: Remove duplicate discipline definition files (dead code)

Fixed: Deleted 4 duplicate discipline definition files (base-disciplines.ts, enchanter-disciplines.ts, fabricator-disciplines.ts, invoker-disciplines.ts) that had incompatible types and conflicting…

Anexim closed issue Anexim/Mana-Loop#32 2026-05-18 20:58:23 +02:00
chore: Remove duplicate LootInventoryDisplay component
Anexim commented on issue Anexim/Mana-Loop#32 2026-05-18 20:58:23 +02:00
chore: Remove duplicate LootInventoryDisplay component

Fixed: Deleted duplicate LootInventoryDisplay.tsx (kept index.tsx as canonical). Both were orphaned anyway.

Anexim closed issue Anexim/Mana-Loop#33 2026-05-18 20:58:23 +02:00
fix: DisciplinesTab.tsx uses getState() during render — breaks React subscription
Anexim commented on issue Anexim/Mana-Loop#33 2026-05-18 20:58:23 +02:00
fix: DisciplinesTab.tsx uses getState() during render — breaks React subscription

Fixed: Refactored DisciplinesTab.tsx to pass discipline state and toggle handler as props to DisciplineCard, eliminating getState() calls during render. The parent component now subscribes to the…

Anexim closed issue Anexim/Mana-Loop#30 2026-05-18 20:58:22 +02:00
fix: canEquipInSlot uses instance ID as type ID — two-handed weapon check broken
Anexim commented on issue Anexim/Mana-Loop#30 2026-05-18 20:58:22 +02:00
fix: canEquipInSlot uses instance ID as type ID — two-handed weapon check broken

Fixed: canEquipInSlot now accepts an optional instances parameter and looks up the main hand instance before getting its type. Updated call site in equipment-actions.ts to pass state.equipmentIns…

Anexim closed issue Anexim/Mana-Loop#31 2026-05-18 20:58:22 +02:00
chore: Remove duplicate discipline definition files (dead code)
Anexim closed issue Anexim/Mana-Loop#29 2026-05-18 20:42:04 +02:00
fix: gameStore.ts passes empty object to processCombatTick as first argument
Anexim commented on issue Anexim/Mana-Loop#29 2026-05-18 20:42:04 +02:00
fix: gameStore.ts passes empty object to processCombatTick as first argument

Fixed: Removed empty object {} first argument from processCombatTick call in gameStore.ts. The wrapper already binds get/set internally.

Anexim closed issue Anexim/Mana-Loop#27 2026-05-18 20:42:03 +02:00
fix: combatStore.ts persist partialize saves wrong field for activeSpell
Anexim commented on issue Anexim/Mana-Loop#27 2026-05-18 20:42:03 +02:00
fix: combatStore.ts persist partialize saves wrong field for activeSpell

Fixed: Changed activeSpell: state.activeAction to activeSpell: state.activeSpell in combatStore.ts partialize

Anexim closed issue Anexim/Mana-Loop#28 2026-05-18 20:42:03 +02:00
fix: totalManaGathered incorrectly accumulates spell costs instead of mana gathered
Anexim commented on issue Anexim/Mana-Loop#28 2026-05-18 20:42:03 +02:00
fix: totalManaGathered incorrectly accumulates spell costs instead of mana gathered

Fixed: Removed totalManaGathered += spellDef.cost.amount from both spell cast loops in combat-actions.ts. Mana gathering should only happen in gatherMana and passive regen.