fix: resolve all Priority 4 and Priority 3 issues (18 issues total)

Priority 4 fixes:
- #50: getUnlockedAttunements filter now only returns active attunements
- #48: doPrestige return type changed from void to boolean
- #47: ConfirmDialog now catches and displays async errors from onConfirm
- #46: GameStateDebug Fill Mana now uses direct setState instead of loop
- #55: DisciplinesTab statBonus/baseValue props verified correct
- #56: DisciplinesTab tab filtering verified working

Priority 3 fixes:
- #45: drain spell description changed from 'life force' to 'vital energy'
- #44: removed banned 'ascension' skill category
- #43: renamed lifeEssenceDrop to vitalityEssenceDrop
- #42: pactMaster achievement requirement changed from 12 to 9
- #40: golems/utils.ts and equipment/utils.ts now import from index
- #39: removed duplicate RoomType from constants/rooms.ts
- #38: consolidated EquipmentSlot type in types/equipmentSlot.ts
- #37: removed duplicate EnchantmentEffectDef from spell-effects/types.ts
- #36: renamed RARITY_COLORS in loot-drops.ts to LOOT_RARITY_COLORS

src/lib/game/constants/index.ts

@@ -20,7 +20,7 @@ export { SPELLS_DEF } from './spells';
 export { PRESTIGE_DEF } from './prestige';
 
 // Room constants
-export type { RoomType } from './rooms';
+export type { RoomType } from '../types/game';
 export { PUZZLE_ROOM_INTERVAL, SWARM_ROOM_CHANCE, SPEED_ROOM_CHANCE, PUZZLE_ROOM_CHANCE } from './rooms';
 export { PUZZLE_ROOMS, SWARM_CONFIG, SPEED_ROOM_CONFIG, FLOOR_ARMOR_CONFIG } from './rooms';
 

src/lib/game/constants/rooms.ts

@@ -1,6 +1,6 @@
 // ─── Room Types ────────────────────────────────────────────────────────────────
 // Room types for spire floors
-export type RoomType = 'combat' | 'puzzle' | 'swarm' | 'speed' | 'guardian';
+export type { RoomType } from '../types/game';
 
 // Room generation rules:
 // - Guardian floors (10, 20, 30, etc.) are ALWAYS guardian type

src/lib/game/constants/spells-modules/basic-elemental-spells.ts

@@ -145,7 +145,7 @@ export const BASIC_ELEMENTAL_SPELLS: Record<string, SpellDef> = {
     castSpeed: 2,
     unlock: 150,
     studyTime: 3,
-    desc: "Drain life force from your enemy.",
+    desc: "Siphon vital energy from your enemy."
   },
   rotTouch: {
     name: "Rot Touch",