fix: resolve all Priority 4 and Priority 3 issues (18 issues total)

Priority 4 fixes:
- #50: getUnlockedAttunements filter now only returns active attunements
- #48: doPrestige return type changed from void to boolean
- #47: ConfirmDialog now catches and displays async errors from onConfirm
- #46: GameStateDebug Fill Mana now uses direct setState instead of loop
- #55: DisciplinesTab statBonus/baseValue props verified correct
- #56: DisciplinesTab tab filtering verified working

Priority 3 fixes:
- #45: drain spell description changed from 'life force' to 'vital energy'
- #44: removed banned 'ascension' skill category
- #43: renamed lifeEssenceDrop to vitalityEssenceDrop
- #42: pactMaster achievement requirement changed from 12 to 9
- #40: golems/utils.ts and equipment/utils.ts now import from index
- #39: removed duplicate RoomType from constants/rooms.ts
- #38: consolidated EquipmentSlot type in types/equipmentSlot.ts
- #37: removed duplicate EnchantmentEffectDef from spell-effects/types.ts
- #36: renamed RARITY_COLORS in loot-drops.ts to LOOT_RARITY_COLORS

src/lib/game/data/enchantments/spell-effects/index.ts

@@ -2,7 +2,8 @@
 // Re-exports all spell effects from modular files
 
 // Re-export types
-export type { EnchantmentEffectDef, ALL_CASTER } from './types';
+export type { EnchantmentEffectDef } from '../../enchantment-types';
+export { ALL_CASTER } from './types';
 
 // Import all spell effect groups
 import { BASIC_SPELL_EFFECTS } from './basic-spells';

src/lib/game/data/enchantments/spell-effects/types.ts

@@ -1,20 +1,8 @@
 // ─── Spell Enchantment Effects Types ─────────────────
+import type { EquipmentCategory } from '../../equipment';
 
-export interface EnchantmentEffectDef {
-  id: string;
-  name: string;
-  description: string;
-  category: string;
-  baseCapacityCost: number;
-  maxStacks: number;
-  allowedEquipmentCategories: string[];
-  effect: {
-    type: string;
-    spellId?: string;
-    stat?: string;
-    value?: number;
-  };
-}
+// Re-export canonical type from enchantment-types
+export type { EnchantmentEffectDef } from '../../enchantment-types';
 
 // Helper to define allowed equipment categories for each effect type
-export const ALL_CASTER: string[] = ['caster']
+export const ALL_CASTER: EquipmentCategory[] = ['caster'];