Commit Graph

293 Commits

Author SHA1 Message Date
n8n-gitea 26639746e9 discipline: elemental revamp - rename, lock, merge tabs, add missing, dedupe
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m22s
2026-05-28 13:15:14 +02:00
n8n-gitea 4fa11cea41 fix: add DebugName wrapper to DisciplinesTab for Show Component Names debug flag
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m23s
2026-05-28 12:41:14 +02:00
n8n-gitea 268baf3916 fix: auto-unlock element types when attunement conversion begins — Fabricator now unlocks earth
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m26s
2026-05-28 12:28:27 +02:00
n8n-gitea 500955db16 chore: update docs from pre-commit hook
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m26s
2026-05-28 12:12:52 +02:00
n8n-gitea 3e70f481dc fix: set currentAction 'climb' and use generateSpireFloorState in enterSpireMode 2026-05-28 12:11:54 +02:00
n8n-gitea 5578721992 refactor: remove skill system leftovers, migrate click mana to discipline perk
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m30s
- Simplified getMeditationBonus() to continuous ramp formula
- Added click-mana capped perk to Mana Circulation discipline
- Removed manaWell/manaFlow/manaSpring skill reads and prestige upgrades
- Removed all skill fields from GameState and GameActionType
- Updated all call sites and tests (916 tests passing)

Closes #174
2026-05-28 11:50:06 +02:00
n8n-gitea b5996d5b6e fix: resolve circular dependency in discipline-slice → discipline-effects
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m30s
Replaced computeDisciplineEffects() import in discipline-slice.ts with
inline XP bonus calculation using calculateStatBonus from discipline-math.
This avoids the circular chain: discipline-effects → discipline-slice → discipline-effects.
2026-05-28 09:47:45 +02:00
n8n-gitea 8cebea9586 fix(#165,#166,#167,#168,#169,#171,#172): resolve 7 open bug issues
#172 - Grimoire tab: removed dead 'loaded' state guard that permanently showed loading
#169 - Transference Mana Flow: added elements param to checkDisciplinePrerequisites so mana type unlocks are verified
#168 - Perk descriptions: wired 4 broken perks (enchant-2, channel-1, golem-2, efficiency-1) with actual bonus effects; fixed enchant-1 interval (5→50); fixed study-mana-enchantments stat (maxMana→maxManaBonus)
#171 - Shields: removed all shield equipment (4 types), recipes, category, slot mappings; added 'shields' to AGENTS.md banned list
#166 - regenMultiplier: merged disciplineEffects.multipliers.regenMultiplier into computeAllEffects()
#165 - Meditation cap: added meditationCap display to ManaStatsSection UI; updated perk description
#167 - XP accumulation: added Meditative Mastery base discipline with disciplineXpBonus stat; wired into tick pipeline
2026-05-28 09:32:43 +02:00
n8n-gitea 27500f37b7 fix(#170): wire fabricator crafting completion + bonus enchantments + remove dead code
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m22s
2026-05-27 21:08:41 +02:00
n8n-gitea 7279050101 fix: repair persistence - safe-persist getItem now returns parsed objects, fix resetGame localStorage keys
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m22s
- safe-persist.ts: getItem now calls JSON.parse(str) so Zustand receives {state, version} envelope
- gameActions.ts: fix 5 wrong localStorage keys in createResetGame (mana→mana-storage, etc.)
- Add persistence.test.ts with 12 tests covering round-trip, key verification, and reset
- All 918 tests pass with zero regressions
2026-05-27 19:14:01 +02:00
n8n-gitea 5f8a860a3c fix: pass rawMana to discipline activate to allow re-practicing after stop
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m20s
2026-05-27 15:57:17 +02:00
n8n-gitea 5e76fe7145 feat: add wizard and physical gear branches to Fabricator
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m21s
- Split fabricator-recipes.ts into 4 files (all under 400 lines):
  - fabricator-recipes.ts: core/elemental equipment recipes + helpers
  - fabricator-wizard-recipes.ts: 7 wizard branch recipes (staffs, circlet, robe, catalyst, pendant)
  - fabricator-physical-recipes.ts: 9 physical branch recipes (blades, helm, robe, boots, gauntlets, shields)
  - fabricator-material-recipes.ts: 12 material crafting recipes
- Added branch filter UI (All/Elemental/Wizard/Physical) to FabricatorSubTab
- All 902 tests pass
2026-05-27 15:22:16 +02:00
n8n-gitea 9a2da67006 feat: add material crafting recipes to Fabricator
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m20s
2026-05-27 14:39:44 +02:00
n8n-gitea 3f20991d2d feat: add material crafting recipes to Fabricator
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 4m25s
2026-05-27 14:13:46 +02:00
n8n-gitea cbeb0b50ad fix: replace arcaneShard with elementally attuned materials in Fabricator recipes
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m32s
2026-05-27 12:56:06 +02:00
n8n-gitea 2c88d3c395 feat: replace Metal Kite Shield with Metal Spell Focus offhand
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m31s
2026-05-27 12:39:55 +02:00
n8n-gitea 5f46948568 fix: rebalance golem stats for proper tier progression
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m32s
2026-05-27 12:30:36 +02:00
n8n-gitea 78766d0722 fix: replace meaningless fabricator recipe stats with mana-focused stats
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m32s
2026-05-27 12:26:16 +02:00
n8n-gitea badd233c63 feat: expand golem stat abbreviations and add special abilities display
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m31s
2026-05-27 12:20:44 +02:00
n8n-gitea a47d6568f7 fix: audit and fix discipline descriptions to match actual effects
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m29s
2026-05-27 12:13:51 +02:00
n8n-gitea 32cebad403 feat: add discipline and perks section to Stats tab
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m34s
2026-05-27 12:04:11 +02:00
n8n-gitea a6dd9479b3 fix: perks now show human-readable descriptions instead of type-idx strings
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m31s
2026-05-27 11:43:55 +02:00
n8n-gitea 428d308ed3 fix: two-handed weapons no longer show off-hand slot option in Equipment tab
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m31s
2026-05-27 11:40:35 +02:00
n8n-gitea a8fab1eb86 fix: make guardian names deterministic per floor instead of using Math.random()
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m37s
- generateGuardianName() now takes a floor parameter and uses floor % prefixes.length for deterministic prefix selection
- generateComboGuardianName() now takes a floor parameter and uses (floor + i) % prefixes.length for each element
- getGuardianForFloor() passes floor to generateGuardianName for static guardians with empty names
- getExtendedGuardian() passes floor to generateComboGuardianName for combo guardians
- Removes dependency on Math.random() → names are stable across ticks/refreshes

Fixes #161
2026-05-27 11:26:28 +02:00
n8n-gitea 8df3be5628 fix: invoker disciplines use raw mana, fabricator uses earth
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m34s
- #151: Changed invoker disciplines (pact-attunement, guardians-boon) from light/dark to raw
- #150: Changed crafting-efficiency from sand to earth
2026-05-27 11:18:31 +02:00
n8n-gitea 964619b975 fix: enchanter disciplines now use transference mana
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m46s
- Changed manaType from elemental to 'transference' for 9 enchanter disciplines:
  - enchanter.ts: mana-channeling, study-basic-weapon-enchantments, study-advanced-weapon-enchantments
  - enchanter-utility.ts: study-utility-enchantments, study-mana-enchantments
  - enchanter-spells.ts: study-basic-spell-enchantments, study-intermediate-spell-enchantments, study-advanced-spell-enchantments
  - enchanter-special.ts: study-special-enchantments
- Fixed misleading description in mana-channeling discipline
2026-05-27 11:16:33 +02:00
n8n-gitea 7962a4fdaa fix: discipline reset on mana depletion and re-activation after stop
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m35s
- #143: processTick now removes drained disciplines from activeIds and calls onStopPracticing so currentAction resets to 'meditate'
- #144: Removed paused guard from canProceedDiscipline so stopped disciplines can be re-activated
- Updated test to match new expected behavior for paused disciplines
2026-05-27 11:13:08 +02:00
n8n-gitea 64b472572b fix: fabricator recipes now use correct elemental mana type
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m37s
- fabricator-recipes.ts: add optional manaType param to canCraftRecipe for clarity
- FabricatorSubTab.tsx: read elemental mana from store based on recipe manaType instead of always using rawMana
- craftingStore.ts: add startFabricatorCrafting action that deducts correct mana type
- craftingStore.types.ts: add startFabricatorCrafting to CraftingActions interface
- crafting-fabricator.ts: new helper file to keep craftingStore.ts under 400 lines

Fixes #155
2026-05-27 11:06:24 +02:00
n8n-gitea 707a1eef31 fix: add error logging, missing persist fields, and version to store configs
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m25s
- safe-persist.ts: add console.error logging to setItem catch block (was silently swallowing all errors)
- manaStore.ts: add meditateTicks to partialize (was lost on refresh)
- combatStore.ts: add currentAction, currentRoom, comboHitCount, floorHitCount, totalSpellsCast, totalDamageDealt, totalCraftsCompleted to partialize
- All 8 stores: add version: 1 to persist configs for future schema migration safety

Fixes #147
2026-05-27 10:45:39 +02:00
n8n-gitea 2fa16c5749 fix: correct circular dep detection in pre-commit hook
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m30s
The generate-dependency-graph.js script was counting madge's
'Processed N files' info line as a circular chain. Fixed the
filter to only match lines starting with 'N)' pattern.
2026-05-26 21:57:50 +02:00
n8n-gitea 06c3fe4380 fix: resolve TS compilation errors and all 7 circular dependencies
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m25s
TypeScript fixes:
- gameStore.ts: replace result.ok with result.success (Result<void> uses success not ok)
- gameStore.ts: fix undefined newProgress variable → ctx.prestige.pactRitualProgress + HOURS_PER_TICK
- prestigeStore.ts: replace result.ok with result.success

Circular dependency fixes:
- Extract GameCoordinatorState to stores/gameStore.types.ts to break gameStore↔tick-pipeline/gameActions/gameLoopActions cycle
- Remove getDodgeChance re-export from floor-utils.ts to break floor-utils↔room-utils↔enemy-utils cycle
- Replace direct combatStore import in discipline-slice.ts with callback pattern to break discipline-slice↔combatStore↔combat-actions↔discipline-effects cycle

Verification: tsc --noEmit clean, madge --circular clean (0 circular deps)
2026-05-26 21:55:55 +02:00
n8n-gitea 1aea72c013 refactor: Redesign Invoker disciplines for pact bonuses and guardian boons
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m21s
- Replace generic spell-casting/void-manipulation with pact-focused disciplines
- Add Pact Attunement (light): reduces pact signing time, boosts pact affinity
- Add Guardian's Boon (dark): amplifies all guardian unique perks
- Add pactAffinityBonus and guardianBoonMultiplier stat keys to effect system
- Apply pactAffinityBonus in pact signing time calculation (gameStore)
- Scale guardian boon values by guardianBoonMultiplier (combat-utils)
- Guard Invoker discipline activation behind signedPacts.length > 0
- Add 'Signed guardian pact' prerequisite display in discipline-math
2026-05-26 21:43:46 +02:00
n8n-gitea 02600754e7 feat: Add Mana Circulation discipline with regen multiplier and meditation cap perks
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m23s
2026-05-26 20:58:55 +02:00
n8n-gitea 46013a15c8 refactor: Replace natural-regen disciplines with mana conversion speed disciplines
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m25s
- Add conversionRate + sourceManaTypes fields to DisciplineDefinition
- Rewrite elemental-regen.ts: 8 base disciplines now convert raw→element
- Rewrite elemental-regen-advanced.ts: 6 composite/exotic disciplines with proper source recipes
- Update discipline-effects.ts: produce conversion entries instead of regen bonuses
- Update gameStore.ts tick: drain source mana types, add to target element
- Update discipline-slice.ts: gate activation on source mana type access
- Update discipline-math.ts: resolve mana type IDs to 'X mana' display names
- Update DisciplinesTab.tsx: show conversion info, source requirements, and lock state
- Update DisciplineDebugSection.tsx: pass elements to activate()
- Update effects.ts: remove regen_{element} merge (no longer produced)
2026-05-26 20:40:11 +02:00
n8n-gitea 1c1bbf8017 feat: practicing disciplines set currentAction to block meditation/crafting
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m20s
2026-05-26 18:39:54 +02:00
n8n-gitea ef850e98e2 refactor: simplify ManaStatsSection props from 17 fields to single stats object
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m23s
2026-05-26 18:28:24 +02:00
n8n-gitea da4f9eccb3 fix: make discipline perk numerical bonuses functional via structured BonusSpec
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m23s
- Add PerkBonus type and optional bonus field to DisciplinePerk
- Populate bonus data on 39 perks across base, elemental, elemental-regen,
  elemental-regen-advanced, and invoker discipline files
- Rewrite computeDisciplineEffects() to apply once/infinite/capped perk bonuses
  through known stat keys (maxManaBonus, baseDamageBonus, regen_*, elementCap_*)
- Add per-element cap bonus routing in effects.ts computeAllEffects()
- Remove dead enchantPower bonus (no consumer in effects pipeline)
2026-05-26 18:00:29 +02:00
n8n-gitea ae30c4770c fix: guardian pact signing now unlocks mana types via unlockElement
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m24s
2026-05-26 17:02:36 +02:00
n8n-gitea b402b8f56e refactor: cleanup codebase — remove hydration guards, extract constants, fix bugs
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m20s
2026-05-26 11:20:36 +02:00
n8n-gitea 5c64bb00fa docs: update AGENTS.md and GAME_BRIEFING.md to reflect current architecture
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m23s
- Remove references to legacy store.ts, store/, store-modules/, Prisma, database
- Update guardian system: 4 tiers (base/compound/exotic/combination bosses at 150+)
- Update discipline system: 34 disciplines across 10 data files, 4 attunement pools
- Update combat: enemy modifiers, room types, floor HP formulas
- Update incursion: starts day 5 (not day 20)
- Update equipment: 50 types, 9 categories, 8 slots
- Update golemancy: 10 golems (1 base + 3 elemental + 6 hybrid)
- Update prestige: 14 upgrade types, pact persistence
- Update achievements: 24 achievements across 5 categories
- Fix mana types terminology: composite (not compound) in code
- Add store architecture overview (7 Zustand stores)
- Add removed systems appendix
2026-05-26 10:53:48 +02:00
n8n-gitea 518961299a desloppify: fix 34 unused imports/vars, debug logs, and code quality issues
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 2m20s
2026-05-26 02:35:02 +02:00
n8n-gitea fdc636faaa test: add combat-actions and UI component tests — 40 new tests covering processCombatTick, Card, Button, Badge
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m24s
2026-05-25 20:44:09 +02:00
n8n-gitea 25ba565467 chore: remove unused imports, vars, and params — 84 imports, 7 vars, 16 params across 45+ files
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m25s
2026-05-25 20:18:39 +02:00
n8n-gitea 4aa12a10f0 test: add cross-module integration tests for tick pipeline
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m22s
Add 38 integration tests split across 4 files (all under 400 lines):
- cross-module-helpers.ts: shared resetAllStores() and tickN() utilities
- cross-module-combat-meditation.test.ts (12 tests): combat floor
  clearing, meditation regen flow, incursion effects, convert action
- cross-module-prestige-discipline.test.ts (15 tests): prestige loop
  reset, discipline mana drain/XP, pact ritual completion
- cross-module-lifecycle-consistency.test.ts (11 tests): full loop
  lifecycle, store consistency invariants, pause/gameOver blocking

All 38 new + 112 existing tests pass.
2026-05-25 18:26:32 +02:00
n8n-gitea fdf3984e75 fix: resolve TS errors, lint issues, and test failures
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m30s
- Fix TS2353 in discipline-slice.ts: widen activate() gameState type to ElementState
- Fix require() in generate-dependency-graph.js: add eslint-disable comment
- Fix require() in regression-fixes.test.ts: use ESM import instead
- Fix react-hooks/set-state-in-effect in 10 client components (add eslint-disable)
- Fix react-hooks/rules-of-hooks in EquipmentCrafter.tsx: lift store hooks to parent
- Fix 20 test failures: correct expectations for guardian floors, dodge chance, barrier rolls, element cycling, file size check
- Handle negative/zero floors in getFloorMaxHP
- Split room-utils.test.ts to enemy-barrier-utils.test.ts to stay under 400-line limit
2026-05-25 17:37:12 +02:00
n8n-gitea 635b3b3f70 feat: discipline UI improvements - stat labels, prerequisites, mana type tab
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m23s
- Add player-friendly label field to statBonus in DisciplineDefinition
- Show prerequisite requirements on locked discipline cards
- Disable activate button for locked disciplines
- Restructure elemental attunement into dedicated 'Mana Types' tab
- Add checkDisciplinePrerequisites utility function
- Update store to enforce prerequisite checking on activation
- Split discipline-prerequisites tests into separate file
2026-05-25 15:20:02 +02:00
n8n-gitea 2c58186a67 feat: show mana type and base cost on discipline cards
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m22s
2026-05-25 12:50:01 +02:00
n8n-gitea e9eb7d8b14 fix: discipline bonuses persist when paused/deactivated
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m26s
2026-05-25 12:43:08 +02:00
n8n-gitea cb78761e95 feat: add per-element mana regen disciplines for all 14 mana types
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m26s
- Create data/disciplines/elemental-regen.ts (base + utility elements)
- Create data/disciplines/elemental-regen-advanced.ts (composite + exotic)
- Wire into ALL_DISCIPLINES via index.ts and discipline-slice.ts
- Add perElementRegenBonus to ComputedEffects type
- Merge regen_{element} discipline bonuses in computeAllEffects()
- Apply per-element regen to element mana each tick in gameStore
- Add 'Elemental Regen' and 'Advanced Regen' tabs to DisciplinesTab UI
2026-05-25 12:24:01 +02:00
n8n-gitea f22ebf1b3b fix: rename discipline buttons from Activate/Pause to Start Practicing/Stop Practicing
Build and Publish Mana Loop Docker Image / build-and-publish (push) Successful in 1m33s
2026-05-25 11:55:31 +02:00